Fisheye on td-firmware/firmware/App/Services/TxParams.c https://devapps.diality.us/changelog/~br%3DLDT-4002-hdf-fw-implementation/td-firmware/firmware/App/Services/TxParams.c Recent activity in "td-firmware" under directory /firmware/App/Services/TxParams.c LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Use the NEARLY_ZERO constant (instead 0f 0.01F)..." Wed, 27 May 2026 13:22:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29403 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29403 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Add a doxygen comment above this array." Wed, 27 May 2026 13:07:19 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29402 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29402 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Add a doxygen comment above this array.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Add a doxygen comment above this array (similar..." Wed, 27 May 2026 13:06:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29401 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29401 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Add a doxygen comment above this array (similar to structures).

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Add a doxygen comment above structure for the w..." Wed, 27 May 2026 13:04:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29400 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29400 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Add a doxygen comment above structure for the whole structure (see structure above for example).

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Add a doxygen comment for this definition." Wed, 27 May 2026 13:03:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29399 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29399 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Add a doxygen comment for this definition.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Raghu Kallala "remove camel case for SetPoint, instead use Set..." Tue, 26 May 2026 11:29:59 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29349 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29349 Raghu Kallala commented on LEAHI-TD-FIRMWARE-LDT-3970-1

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Can we rename this to TREATMENT_DURATION_CONFIR..." Tue, 26 May 2026 11:15:11 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29348 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29348 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Can we rename this to TREATMENT_DURATION_VALIDA..." Tue, 26 May 2026 11:14:51 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29347 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29347 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "What is the difference between the bicarbonateC..." Tue, 26 May 2026 11:10:26 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29346 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29346 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Looks like comment for 208 and 223 are swapped?" Tue, 26 May 2026 11:09:21 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29345 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29345 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Looks like comment for 208 and 223 are swapped?

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "please align the comments" Tue, 26 May 2026 11:07:35 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29344 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29344 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

please align the comments

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please update the msg id to MSG_ID_TD_TREATMENT..." Tue, 26 May 2026 10:36:24 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29343 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29343 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines and check other ..." Tue, 26 May 2026 10:30:21 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29340 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29340 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines and check other functions too.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines" Tue, 26 May 2026 10:30:30 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29341 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29341 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines" Tue, 26 May 2026 10:29:57 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29339 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29339 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines Should the name..." Tue, 26 May 2026 10:26:14 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29338 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29338 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines" Tue, 26 May 2026 10:22:39 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29337 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29337 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines" Tue, 26 May 2026 10:21:06 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29336 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29336 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines" Tue, 26 May 2026 10:15:20 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29335 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29335 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "Please break it into two lines" Tue, 26 May 2026 10:14:25 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29334 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29334 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please break it into two lines

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "TREAT_PARAMS_PROPERTIES should also be an input..." Tue, 26 May 2026 10:13:07 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29333 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29333 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

TREAT_PARAMS_PROPERTIES should also be an input?

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "please add @param" Tue, 26 May 2026 10:05:22 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29331 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29331 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

please add @param

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Vendor - TEL - Arpita Srivastava "please align the comment" Tue, 26 May 2026 10:04:17 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29330 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29330 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

please align the comment

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Is this the right time to zero this volume?" Wed, 20 May 2026 12:14:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29238 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29238 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Is this the right time to zero this volume?

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "update total volume too?" Wed, 20 May 2026 12:13:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29237 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29237 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

update total volume too?

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "maybe use target rate for both." Wed, 20 May 2026 12:09:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29236 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29236 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

maybe use target rate for both.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Use #define for array size." Wed, 20 May 2026 11:41:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29235 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29235 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Use #define for array size.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Make the 6 a #define" Wed, 20 May 2026 11:40:36 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29234 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29234 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Make the 6 a #define

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "only 1 return statement" Wed, 20 May 2026 11:37:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29233 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29233 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

only 1 return statement

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "remove comma" Wed, 20 May 2026 11:35:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29232 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29232 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

remove comma

]]>