We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

Remove this blank line.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

This merge conflict is still unresolved.

leak in the comment section.

Where is alarm 191..203?

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Why was this function header changed? I think it was correct before.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

I missed updating this earlier, I’ll push the updated code.

Can't have 3 values. Maximum 2 values allowed.

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

align comment

The Id name looks too long? What if we change Temperature to Temp?

Removedd

added

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

Please add a comment for this check and break the line in two lines.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please rename this function to initTreatmentParameters

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

Please indent the doxygen comments of all the functions, similar to existing functions.

Updated

origTreatmentParams should be an output?