All these are more of debug related overrides (acid and bicarb P & I gain). you can keep them in one function, when the implementation is complete, you may remove these. The init function is too big, group them and split in the functions and call here.

Some of these parameters can be changed over td proxy commands, need not to implement additional overrides.

I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during treatment.

looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.

33.0?

Add comment for each macro.

For all floats add F at the end, across the file.

Align the comment

restored

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Should be #ifndef

Should be #ifndef I think.

Can we make these low priority and 999 rank?

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Add a blank line after banner.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?

align the indent.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

I had this commented again to push to the develop branch. It is uncommented for my testing.