Are we done testing? Can we remote test variables and code?

Remove Sequence step states if not being used.

Update comments ( remove start/end states)

Update TD to DD.

Update alarm properties (DD fault, Priority eti,.)

Remove the empty line.

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Remove commented code.

Remove D34 valve close.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

void inside paranthesis.

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that this function will check the condition and skip the valves actions if not met. this is not the expected behavior.

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

Open D80, not D85.

Remove the commented code.

Update description across the file.

Update description.

update the description.

You need to initialize the valve states and timer etc., as similar to when you jump from idle state to fill water state. Fill water state just checks the pressure check condition.

Add TODO comment that it should be removed later.

Add comment.

Set default publish interval to 1 sec.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

· /DDDefs.h

(-2, +2)

| History

| Source

| Diff

]]> Tue, 11 Aug 2026 14:40:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4500-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4500-1 Dara Navaei and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4500-1 LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill ]]> Tue, 11 Aug 2026 11:49:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31192 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31192 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Remove empty line.