leahi-common

Clone Tools

Stats

Commits this week: 31
Total Committers: 18
Last Commit: 04 May
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 May
4:30 pm

Sean Nash

check alarm status instead of switch state.

check alarm status instead of switch state.

4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

11:04 am

Vendor - TEL - Varshini Nagabooshanam

Uncommented

Uncommented

10:19 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -6
    • +11
    /MsgDefs.h
    • -38
    • +84
    /TDDefs.h
9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

7:18 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-3978-switch-chamber-f-conductive-lev into staging

Options
12:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

Sunday 03 May
11:59 pm

Sean Nash

Why is this service prefixed with "Tx"? Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

11:57 pm

Sean Nash

DrySelfTests unit.

DrySelfTests unit.

11:57 pm

Sean Nash

DrySelfTests unit initialized.

DrySelfTests unit initialized.

11:56 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:55 pm

Sean Nash

.. handles dry self-tests execution for pre-treatment and treatment modes.

.. handles dry self-tests execution for pre-treatment and treatment modes.

11:54 pm

Sean Nash

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

11:52 pm

Sean Nash

Calling signal function here seems circular (that's how we got here in the first place). Shouldn't we set state to the install state here instead?

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

11:50 pm

Sean Nash

Put before TxParams.

Put before TxParams.

11:50 pm

Sean Nash

I think Praneeth created a function for this. Make sure they're identical.

I think Praneeth created a function for this. Make sure they're identical.

11:46 pm

Sean Nash

11:46 pm

Sean Nash

11:45 pm

Sean Nash

11:44 pm

Sean Nash

11:43 pm

Sean Nash

Is the folder name necessary?

Is the folder name necessary?

11:42 pm

Sean Nash

Remove unnecessary spaces before =

Remove unnecessary spaces before =

11:41 pm

Sean Nash

Align =

Align =

11:41 pm

Sean Nash

Align =.

Align =.

11:41 pm

Sean Nash

Align =.

Align =.

11:40 pm

Sean Nash

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.