leahi-common

Clone Tools

Stats

Commits this week: 11
Total Committers: 16
Last Commit: 13 Mar
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

2:30 pm

Sean Nash and Michael Garthwaite

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?

12:55 pm

Sean Nash

This is a structure, not an enumeration.

This is a structure, not an enumeration.

Tuesday 17 Mar
9:46 pm

Sean Nash

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:56 pm

Sean Nash

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:53 pm

Sean Nash

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:50 pm

Sean Nash

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:15 pm

Sean Nash

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:03 pm

Sean Nash

9:58 am

Sean Nash

Wrong place.

Wrong place.

9:57 am

Sean Nash

I'll drop by and we can set properties together.

I'll drop by and we can set properties together.

7:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
Monday 16 Mar
5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated