Fisheye on leahi-common/DDDefs.h https://devapps.diality.us/changelog/~br%3DLDT-4024-disinfection-dd-heat-heatdescal/leahi-common/DDDefs.h Recent activity in "leahi-common" under directory /DDDefs.h LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Michael Garthwaite "fix the id back to 255 in the struct" Wed, 19 Aug 2026 13:07:29 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31495 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31495 Michael Garthwaite commented on LEAHI-TD-FIRMWARE-LDT-4050-1

fix the id back to 255 in the struct

]]> LEAHI-DD-FIRMWARE-LDT-4024-1: comment by Vinayakam Mani "Can we add current DD recirculation Dwell Time,..." Wed, 19 Aug 2026 12:10:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31490 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31490 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

]]> LEAHI-DD-FIRMWARE-LDT-4024-1: comment by Vinayakam Mani "Add D92 pump On at 50ml/min." Wed, 19 Aug 2026 11:11:53 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31487 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31487 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

Add D92 pump On at 50ml/min.

]]> LEAHI-DD-FIRMWARE-LDT-4024-1: comment by Vinayakam Mani "Remove D95 from closed state and add D88 to clo..." Wed, 19 Aug 2026 11:08:13 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31485 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31485 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

Remove D95 from closed state and add D88 to closed state.

]]> LEAHI-DD-FIRMWARE-LDT-4024-1: comment by Vinayakam Mani "D35, D40, D34,D91,D95 : Open M12, P39 : Closed..." Wed, 19 Aug 2026 11:02:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31484 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31484 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

]]> LEAHI-DD-FIRMWARE-LDT-4024-1: comment by Vinayakam Mani "close D80, D64, D14?" Wed, 19 Aug 2026 10:59:27 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31483 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31483 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

close D80, D64, D14?

]]> LEAHI-DD-FIRMWARE-LDT-4024-1: comment by Vinayakam Mani "D80 : open, D65: Close?" Wed, 19 Aug 2026 10:55:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31482 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31482 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

D80 : open, D65: Close?

]]> leahi-common (LDT-4024-disinfection-dd-heat-heatdescal): LDT-4024 base implementation for heat disinfection Wed, 19 Aug 2026 09:14:45 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/leahi-common?cs=d99f22c6c8c038791214fad1baa6a48840116edf https://devapps.diality.us/changelog/leahi-common?cs=d99f22c6c8c038791214fad1baa6a48840116edf Vendor - TEL - Jashwant Gantyada committed d99f22c on branch LDT-4024-disinfection-dd-heat-heatdescal in leahi-common LDT-4024 base implementation for heat disinfection

· /DDDefs.h (-1, +14) | History | Source | Diff
· /MsgDefs.h (-0, +1) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-4049-1: closed by Vendor - TEL - Suresh Dharnala Tue, 18 Aug 2026 16:46:15 -0700 Vendor - TEL - Suresh Dharnala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 Vendor - TEL - Suresh Dharnala Closed LEAHI-TD-FIRMWARE-LDT-4049-1 ]]> LEAHI-TD-FIRMWARE-LDT-4049-1: reviewers finished Tue, 18 Aug 2026 16:41:38 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 Vinayakam Mani , Sean Nash and Michael Garthwaite finished reviewing LEAHI-TD-FIRMWARE-LDT-4049-1 LEAHI-TD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2: ]]> LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "This isn't right. Look at staging for correct ..." Tue, 18 Aug 2026 15:48:38 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c31475 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c31475 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

This isn't right. Look at staging for correct code.

]]> LEAHI-DD-FIRMWARE-LDT-5409-1: comment by Sean Nash "I'm seeing a lot of magic numbers. We should h..." Tue, 18 Aug 2026 11:39:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5409-1/#c31470 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5409-1/#c31470 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-5409-1

I'm seeing a lot of magic numbers. We should have #defines for these values.

]]> LEAHI-DD-FIRMWARE-LDT-5409-1: comment by Sean Nash "Add doxygen comments to right." Tue, 18 Aug 2026 11:37:45 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5409-1/#c31469 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5409-1/#c31469 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-5409-1

Add doxygen comments to right.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: reviewers added to LEAHI-TD-FIRMWARE-LDT-4050_Post Treatment - FW Imp... Mon, 17 Aug 2026 17:03:07 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1 Sean Nash added Michael Garthwaite to LEAHI-TD-FIRMWARE-LDT-4050-1 LEAHI-TD-FIRMWARE-LDT-4050_Post Treatment - FW Implementation - 1/3: ]]> LEAHI-TD-FIRMWARE-LDT-4049-1: reviewers added to LEAHI-TD-FIRMWARE-LDT-4049_Standby - FW Implementa... Mon, 17 Aug 2026 16:56:57 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 Sean Nash added Michael Garthwaite to LEAHI-TD-FIRMWARE-LDT-4049-1 LEAHI-TD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2: ]]> LEAHI-DD-FIRMWARE-LDT-4024-1: started by Dara Navaei Mon, 17 Aug 2026 10:16:58 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4024-1 ]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Not needed? Add another BOOL for disinfection ..." Fri, 14 Aug 2026 12:11:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31400 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31400 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Not needed? Add another BOOL for disinfection option received.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Initialize this." Fri, 14 Aug 2026 12:23:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31408 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31408 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Initialize this.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Remove TODO" Fri, 14 Aug 2026 12:15:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31405 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31405 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Remove TODO

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Remove disable of ejector motor." Fri, 14 Aug 2026 12:14:44 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31404 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31404 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Remove disable of ejector motor.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Remove RotaryValve.h. It's obsolete and we sho..." Fri, 14 Aug 2026 12:08:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31394 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31394 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Just move msg handlers from Messaging to here s..." Fri, 14 Aug 2026 12:07:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31393 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31393 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Just move msg handlers from Messaging to here so you don't need a signal.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Move to .c file to make private." Fri, 14 Aug 2026 12:06:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31391 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31391 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Move to .c file to make private.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Not needed." Fri, 14 Aug 2026 12:05:19 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31390 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31390 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Not needed.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Do we need summary review msgs? 0xA9 and 0xAA ..." Fri, 14 Aug 2026 11:18:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31389 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31389 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Missing heat citric" Fri, 14 Aug 2026 11:16:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31388 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31388 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Missing heat citric

]]> LEAHI-TD-FIRMWARE-LDT-4050-1: comment by Sean Nash "Put back to reserved" Fri, 14 Aug 2026 11:09:38 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31387 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4050-1/#c31387 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4050-1

Put back to reserved

]]> LEAHI-DD-FIRMWARE-LDT-5186-1: comment by Vendor - TEL - Sameer Poyil "The current implementation and OR and AND logic..." Fri, 14 Aug 2026 10:35:41 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5186-1/#c31386 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5186-1/#c31386 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-5186-1

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

]]> LEAHI-DD-FIRMWARE-LDT-5186-1: comment by Vendor - TEL - Sameer Poyil "removed" Fri, 14 Aug 2026 10:25:58 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5186-1/#c31385 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5186-1/#c31385 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-5186-1

removed

]]> LEAHI-DD-FIRMWARE-LDT-5186-1: comment by Vendor - TEL - Sameer Poyil "updated" Fri, 14 Aug 2026 10:25:15 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5186-1/#c31384 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5186-1/#c31384 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-5186-1

updated

]]>