· /MessagePayloads.h

(-4, +12)

| History

| Source

| Diff

]]> Wed, 19 Aug 2026 12:10:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31490 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4024-1/#c31490 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4024-1

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

close D80, D64, D14?

D80 : open, D65: Close?

This isn't right. Look at staging for correct code.

I'm seeing a lot of magic numbers. We should have #defines for these values.

Add doxygen comments to right.

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

removed

updated

updated

updated

removed

Shouldn't this be in ModePostTreatment?

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

Update this to work for all standby states w/ switch statement on given "new" state.

Why zeroes? Why not send TD version constants?

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

change enum name too. need 1 alarm for each disinfection type.

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Missing some disinfects.

Move up after HCOL

Are we done testing? Can we remote test variables and code?