This isn't right. Look at staging for correct code.

Shouldn't this be in ModePostTreatment?

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

Update this to work for all standby states w/ switch statement on given "new" state.

Why zeroes? Why not send TD version constants?

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

change enum name too. need 1 alarm for each disinfection type.

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Missing some disinfects.

Move up after HCOL

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Same question as above: should we alarm if the retries failed?

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

If a retry goes wrong will you trigger an alarm?

Any fault alarm here?

Have these variables been initialized correctly?

Remove extra blank line.

We generally don't add { } to switch cases unless they require local variable declarations.