· /firmware/App/Controllers/Valves.c	(-20, +20)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.c	(-46, +116)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-1, +10)	| History	| Source	| Diff
· /firmware/App/Drivers/RotaryValve.c	(-501, +0)	| History	| Source	| Diff
· /firmware/App/Drivers/RotaryValve.h	(-70, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-4, +3)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 09:06:07 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4072-2 LEAHI-TD-FIRMWARE-LDT-4072_Power Loss - FW Implementation - 2/3: ]]> Tue, 21 Jul 2026 17:14:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c30598 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c30598 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

Add comments to right.

2 blank lines before and after.

Move declarations into this if scope.

Remove blank line.

Remove (void)

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Fixed

· /firmware/App/Tasks/TaskGeneral.c	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-0, +3)	| History	| Source	| Diff

]]> Thu, 09 Jul 2026 08:59:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4149-1/#c30390 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4149-1/#c30390 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4149-1

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

this function should not return anything.

Please rename all the sPump registers as h10 for consistency.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Add blank line before return statement.

Fixed

Added

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Yes removed

Fixed

Fixed

fpgaActuatorSetPoints is an output.
Input is none.

Include "BPModule.h".

BPModule is just one of the controllers - move this up into the controllers section.

We should not comment this out.