Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Do we need to check if bicarb chamber level is high, ignore opening D80?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

Align comment

Add comment.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Mon, 27 Apr 2026 22:38:49 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=e7401702a1a442b48fef7acdeef952d33f7e7c17 https://devapps.diality.us/changelog/dd-firmware?cs=e7401702a1a442b48fef7acdeef952d33f7e7c17 Dara Navaei committed e740170 on branch LDT-4188-sw-fw-integration-to-run-a-trea, staging in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	| History	| Source	| Diff

]]> Mon, 27 Apr 2026 13:22:08 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3975-1 ]]> Mon, 27 Apr 2026 12:46:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28707 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28707 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove space after 'Supply'.

Align the value declaration indentation.

looks you are already checking this state in a line above.

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

I think this enum should be in a different header file. I don't think this unit uses this enum.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

I think isSectorStartAddress is a better function name.

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

don't forget to add function headers.

// **************** private functions **************

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

Add a blank line before group end marker.

No load cells in Leahi.

I think this enum belongs to NVRecords (these are records, not jobs).

I think this enum belongs to the Q (these are Q jobs), not in driver.

What about TD record CRC errors?

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.