Fisheye on dd-firmware/firmware/App/Controllers/MixingControl.c https://devapps.diality.us/changelog/~br%3DLDT-4410-dialysate-composition-mixing-2/dd-firmware/firmware/App/Controllers/MixingControl.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/MixingControl.c LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Sean Nash "TODO?" Wed, 08 Jul 2026 14:55:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4614-1

TODO?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line" Wed, 08 Jul 2026 14:21:52 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line." Wed, 08 Jul 2026 14:20:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Please add the details what is post and pre in ..." Wed, 08 Jul 2026 13:58:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove extra line." Wed, 08 Jul 2026 14:01:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove extra line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Is this TODO still valid?" Wed, 08 Jul 2026 13:52:40 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Is this TODO still valid?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Space inside parenthesis. update across the fil..." Wed, 08 Jul 2026 13:50:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Space inside parenthesis. update across the file.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Sean Nash "What is 4 (or 2)? Should be #define or enum or..." Mon, 06 Jul 2026 12:59:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4410-3

What is 4 (or 2)? Should be #define or enum or const.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Add comments." Thu, 02 Jul 2026 15:26:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Add comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Update Comments." Thu, 02 Jul 2026 15:24:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Update Comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Siemens. Space after and before paranthesis." Thu, 02 Jul 2026 15:22:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Siemens. Space after and before paranthesis.

]]> LEAHI-DD-FIRMWARE-LDT-4612-1: closed by Vendor - TEL - Sameer Poyil Wed, 01 Jul 2026 21:08:32 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-4612-1 ]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Sean Nash "Can we be a little more specific about what con..." Wed, 01 Jul 2026 18:34:15 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30331 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30331 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: started by Dara Navaei Wed, 01 Jul 2026 14:32:33 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4614-1 ]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:39 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30294 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30294 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:23 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30293 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30293 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:17 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30292 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30292 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "moved." Wed, 01 Jul 2026 10:32:10 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30291 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30291 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4719-1

moved.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:03 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30290 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30290 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Sean Nash "Move below Messaging.h to keep list in alphabet..." Wed, 01 Jul 2026 09:36:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30268 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30268 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Move below Messaging.h to keep list in alphabetical order.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Same here. Let's use only D29." Tue, 30 Jun 2026 17:09:26 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30262 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30262 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Same here. Let's use only D29.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Suppose to use D74, Instead of D17 (for Control..." Tue, 30 Jun 2026 17:02:45 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30261 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30261 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Suppose to use D74, Instead of D17 (for Control only).

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Move these functions to top area where all publ..." Tue, 30 Jun 2026 16:47:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30258 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30258 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Missing Comment." Tue, 30 Jun 2026 16:44:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30257 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30257 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Missing Comment.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: started by Dara Navaei Tue, 30 Jun 2026 12:47:32 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4719-1 ]]> dd-firmware (LDT-4410-dialysate-composition-mixing-2): LDT-4410 merged latest staging into my branch Fri, 26 Jun 2026 15:08:51 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=43ebe58702128e865210533f9e6deaf13f99d262 https://devapps.diality.us/changelog/dd-firmware?cs=43ebe58702128e865210533f9e6deaf13f99d262 Vendor - TEL - Jashwant Gantyada committed 43ebe58 on branch LDT-4410-dialysate-composition-mixing-2 in dd-firmware LDT-4410 merged latest staging into my branch

· /firmware/App/Controllers/BalancingChamber.c (-1, +29) | History | Source | Diff
· /firmware/App/Controllers/DryBiCart.c (-80, +273) | History | Source | Diff
· /firmware/App/Controllers/MixingControl.c (-9, +23) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Same as above." Fri, 26 Jun 2026 13:41:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30188 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30188 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Same as above.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Add an event here, when time out happens. Event..." Fri, 26 Jun 2026 13:38:06 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30186 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30186 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "You may need to comment/ remove this condition...." Fri, 26 Jun 2026 13:36:20 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30185 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30185 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

]]> LEAHI-DD-FIRMWARE-LDT-4612-1: started by Vendor - TEL - Sameer Poyil Thu, 25 Jun 2026 16:20:58 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-4612-1 ]]>