Remove extra blank line.

We generally don't add { } to switch cases unless they require local variable declarations.

If we're not including a timestamp, can we just remove this line of code?

Why commented out?

Swap order of == for these 2 if statements - put constant on left side.

Why?

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Use ternary operator to explicitly set to TRUE or FALSE.

Our TODO comments are all CAPs.

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return a BOOL (that is what ModeStandby is expecting).

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Align comment.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

0.0F(float type).

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

Should this be the "Load Syringe" alarm that you just added?
Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

Can we remote this TODO comment?

Remove blank line.

We should go to dry self test state. Why did this change to Rx state?

Comment - should be "install" not "instll".

Do we need this?

Change this to work for any state (passed as parameter).

Delete it.

· /DDDefs.h

(-2, +2)

| History

| Source

| Diff

]]> Mon, 20 Jul 2026 16:33:01 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c30552 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c30552 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Remove

Alphabetize these includes.