It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

Add doxygen comments to the right of each structure field.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

Add blank line before return statement.

Keep this blank line above group header.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Make sure UI s/w is looking for this message on the broadcast channel or change this channel to the TD=>UI channel if UI is looking for this message on that channel.

Maintain alphabetical order.

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

What about HDF?

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is being handled in this function.

return result;

Keep local result and set to TRUE or FALSE with a ternary.

Which setting does this message confirm (duration or volume)?

Align comment.

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

do we need this block?

update the comment as required: ml or L?

· /firmware/App/TDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Fri, 29 May 2026 15:24:51 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=a12f3ce494cd2a18aee31659c17d8a619fc70f7d https://devapps.diality.us/changelog/td-firmware?cs=a12f3ce494cd2a18aee31659c17d8a619fc70f7d Dara Navaei committed a12f3ce on branch LDT-4027-pre-treatment---fw-implementation, LDT-4494-update-both-h12-scalar-and-duty, staging in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 29 May 2026 14:57:06 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1 Sean Nash and Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-3970-1 LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4: ]]> Fri, 29 May 2026 14:43:10 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=15f43f3b610abf124dfe827475292c6479492eda https://devapps.diality.us/changelog/td-firmware?cs=15f43f3b610abf124dfe827475292c6479492eda Vendor - TEL - Vijay Pamula committed 15f43f3 on branch LDT-3970-edit-treatment-parameters-during-treatment, LDT-4027-pre-treatment---fw-implementation and 2 more in td-firmware LDT-3970: Addressed review comments for edit treatment parameters

· /firmware/App/Monitors/Pressures.c

(-1, +1)

| History

| Source

| Diff

]]> Fri, 29 May 2026 14:33:51 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29528 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c29528 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Please add the min and max for tmp as well in the outputs.