Fisheye on dd-firmware/firmware/App/Monitors/Conductivity.c https://devapps.diality.us/changelog/~br%3DLDT-4612-dialysate-composition-integ/dd-firmware/firmware/App/Monitors/Conductivity.c Recent activity in "dd-firmware" under directory /firmware/App/Monitors/Conductivity.c LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Update comment. remove TODO if no more applicab..." Mon, 20 Jul 2026 13:55:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30523 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30523 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Update comment. remove TODO if no more applicable.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "FillWaterEndState?" Mon, 20 Jul 2026 13:54:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30522 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30522 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

FillWaterEndState?

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Delete it." Mon, 20 Jul 2026 13:52:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30521 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30521 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Delete it.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Supply state (instead of drain). Updates Inputs..." Mon, 20 Jul 2026 13:49:02 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30520 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30520 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Supply state (instead of drain). Updates Inputs and outputs across the file.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "When the BC fill completed and allow opening D6..." Mon, 20 Jul 2026 13:46:26 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30519 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30519 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

When the BC fill completed and allow opening D65 for Chamber F fill?

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Can we rename this IsDryBicartChamberFillWindow..." Mon, 20 Jul 2026 13:43:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30518 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30518 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "50ms?" Mon, 20 Jul 2026 13:42:50 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30517 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30517 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

50ms?

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Add comment to align with the rest of the imple..." Mon, 20 Jul 2026 13:37:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30515 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30515 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Add comment to align with the rest of the implementation.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "Add outputs as well." Mon, 20 Jul 2026 12:25:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30514 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30514 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

Add outputs as well.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vinayakam Mani "I guess we should have some minimum speed as we..." Mon, 20 Jul 2026 12:14:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30513 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30513 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4410-3

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

]]> LEAHI-DD-FIRMWARE-LDT-4611-4: started by Dara Navaei Wed, 15 Jul 2026 15:03:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4611-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4611-4 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4611-4 ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: closed by Michael Garthwaite Tue, 14 Jul 2026 14:58:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4734-1 ]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "right now pre and post are same. make a TODO to..." Sat, 11 Jul 2026 05:38:45 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30435 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30435 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4410-3

right now pre and post are same. make a TODO to update post later

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "its mixing control interval" Sat, 11 Jul 2026 05:36:31 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30434 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30434 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4410-3

its mixing control interval

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "could you document th math behind the calculati..." Fri, 10 Jul 2026 16:49:14 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30433 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30433 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4410-3

could you document th math behind the calculation also

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Thu, 09 Jul 2026 14:13:11 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Wed, 08 Jul 2026 13:48:01 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Sean Nash "What is 4 (or 2)? Should be #define or enum or..." Mon, 06 Jul 2026 12:59:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4410-3

What is 4 (or 2)? Should be #define or enum or const.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Sameer Poyil "please align this comments with below structure" Wed, 01 Jul 2026 21:04:17 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30334 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30334 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4734-1

please align this comments with below structure

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Sameer Poyil "Please align the comments" Wed, 01 Jul 2026 21:03:36 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30333 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30333 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Please align the comments

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Sameer Poyil "could you please align it ?" Wed, 01 Jul 2026 20:59:54 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30332 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30332 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4734-1

could you please align it ?

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Sean Nash "Add blank line (should be 2 before test support..." Wed, 01 Jul 2026 18:08:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30330 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30330 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Add blank line (should be 2 before test support banner).

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Sean Nash "Remove blank line." Wed, 01 Jul 2026 18:07:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30329 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30329 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Sean Nash "Needs doxygen comments." Wed, 01 Jul 2026 18:06:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Needs doxygen comments.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:18:13 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30314 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30314 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:18:06 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30313 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30313 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:17:58 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30312 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30312 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:17:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30311 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30311 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "Reverted change. Added uncompensated conductivi..." Wed, 01 Jul 2026 13:17:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30310 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30310 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

Reverted change. Added uncompensated conductivity to the conductivity publishing

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vinayakam Mani "space after if." Wed, 01 Jul 2026 11:02:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30302 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30302 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4734-1

space after if.

]]>