Fisheye on td-firmware/firmware/App/Services/DDInterface.c

LEAHI-TD-FIRMWARE-LDT-473-3: reviewers finished

Wed, 22 Apr 2026 09:41:01 -0700

Vinayakam Mani finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Raghu Kallala "Added to be consistent. Once institutional reco..."

Raghu Kallala — Fri, 17 Apr 2026 07:33:15 -0700

Raghu Kallala replied to Vinayakam Mani in LEAHI-TD-FIRMWARE-LDT-473-3

Added to be consistent. Once institutional records are implemented will store it in there instead of a macro

LEAHI-TD-FIRMWARE-LDT-473-3: reviewers resumed

Fri, 17 Apr 2026 07:32:23 -0700

Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-473-3

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Vinayakam Mani "DO we need bicarb conversion factor as well?"

Vinayakam Mani — Wed, 15 Apr 2026 11:33:42 -0700

Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-473-3

DO we need bicarb conversion factor as well?

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "preweight can be non-zero"

Sean Nash — Wed, 15 Apr 2026 09:45:49 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

preweight can be non-zero

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Add blank line after declarations."

Sean Nash — Tue, 14 Apr 2026 13:34:12 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Add blank line after declarations.

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Raghu Kallala "From what I see in UI, it is just a range value..."

Raghu Kallala — Wed, 08 Apr 2026 10:38:58 -0700

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-3

From what I see in UI, it is just a range value not an enum/index

LEAHI-TD-FIRMWARE-LDT-473-3: reviewers added to LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Cr...

Mon, 06 Apr 2026 14:12:26 -0700

Sean Nash added Vinayakam Mani to LEAHI-TD-FIRMWARE-LDT-473-3

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Is it an enum/index like Denali then?"

Sean Nash — Mon, 06 Apr 2026 13:37:21 -0700

Sean Nash replied to Raghu Kallala in LEAHI-TD-FIRMWARE-LDT-473-3

Is it an enum/index like Denali then?

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Raghu Kallala "No we are not getting conv factor from UI on it..."

Raghu Kallala — Mon, 06 Apr 2026 12:42:53 -0700

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-3

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Align comments."

Sean Nash — Mon, 06 Apr 2026 11:01:41 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Align comments.

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove this?"

Sean Nash — Mon, 06 Apr 2026 10:57:42 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove this?

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove this?"

Sean Nash — Mon, 06 Apr 2026 10:57:26 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove this?

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "F suffix."

Sean Nash — Mon, 06 Apr 2026 10:56:14 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

F suffix.

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Is bicarbonate also a conversion factor?"

Sean Nash — Mon, 06 Apr 2026 10:52:06 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Is bicarbonate also a conversion factor?

LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove the old enum now?"

Sean Nash — Mon, 06 Apr 2026 10:49:32 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove the old enum now?

LEAHI-TD-FIRMWARE-LDT-473-3: started by Dara Navaei

Dara Navaei — Mon, 06 Apr 2026 10:16:18 -0700

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-473-3

LEAHI-TD-FIRMWARE-LDT-473-2: closed by Raghu Kallala

Raghu Kallala — Mon, 06 Apr 2026 10:04:42 -0700

Raghu Kallala Closed LEAHI-TD-FIRMWARE-LDT-473-2

LEAHI-TD-FIRMWARE-LDT-473-2: reviewers finished

Wed, 25 Feb 2026 09:19:49 -0800

Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-473-2

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation

td-firmware (LDT-473-treatment-parameters-create-rx-beta): LDT-473 addressed review comments

Raghu Kallala — Fri, 20 Feb 2026 13:50:50 -0800

Raghu Kallala committed 316cb40 on branch LDT-473-treatment-parameters-create-rx-beta in td-firmware

LDT-473 addressed review comments

· /firmware/App/Modes/ModeTreatment.c	(-1, +30)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommTD.c	(-29, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommTD.h	(-4, +1)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Raghu Kallala "Updated"

Raghu Kallala — Fri, 20 Feb 2026 13:42:09 -0800

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

Updated

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Raghu Kallala "Updated"

Raghu Kallala — Fri, 20 Feb 2026 13:36:09 -0800

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

Updated

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Sean Nash "I think this function should be in ModeTreatmen..."

Sean Nash — Fri, 20 Feb 2026 13:35:33 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-2

I think this function should be in ModeTreatment or Messaging.

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Sean Nash "update params in header."

Sean Nash — Fri, 20 Feb 2026 13:34:40 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-2

update params in header.

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Raghu Kallala "you are right, I missed it here. Fixed."

Raghu Kallala — Fri, 20 Feb 2026 13:33:39 -0800

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

you are right, I missed it here.
Fixed.

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Sean Nash "Move pop to be right after last structure to be..."

Sean Nash — Fri, 20 Feb 2026 13:33:19 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-2

Move pop to be right after last structure to be packed.

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Sean Nash "I thought acid fields were F32?"

Sean Nash — Fri, 20 Feb 2026 13:28:07 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-2

I thought acid fields were F32?

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Raghu Kallala "removed both enums"

Raghu Kallala — Fri, 20 Feb 2026 12:39:46 -0800

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

removed both enums

td-firmware (LDT-473-treatment-parameters-create-rx-beta): LDT-473 updated dd dialysate requst msg and added send pressure limit change response

Raghu Kallala — Fri, 20 Feb 2026 11:38:13 -0800

Raghu Kallala committed 11a668a on branch LDT-473-treatment-parameters-create-rx-beta in td-firmware

LDT-473 updated dd dialysate requst msg and added send pressure limit change response

· /firmware/App/Modes/ModeStandby.c	(-5, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-0, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-5, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommTD.c	(-0, +28)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommTD.h	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/TxParams.c	(-9, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/TxParams.h	(-0, +1)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-473-2: comment by Raghu Kallala "Updated"

Raghu Kallala — Fri, 20 Feb 2026 11:26:31 -0800

Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

Updated