Same as above.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

it shouldn't be the default value

Space after if.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

remove empty space after d66pressure variable. or match the indent to previous statement.

Add a TODO comment (remove later): this should be handled in IO/FP module.

Update comment.

Add comment.

Depressurize?

Fix the typo.

moved to general task

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

This should return POST conductivity.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

Init PI Controls missing here.

13734.87F

Can we move this exec at task level, independent of Drybicart operations?

Comment missing?

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

both acid and bicarb mix volume

Add MULTIPLIER at the end.