Fisheye on dd-firmware/ https://devapps.diality.us/changelog/~br%3DLDT-4733-request-add-variables/dd-firmware Recent activity in "dd-firmware" under directory / LEAHI-DD-FIRMWARE-LDT-3902-1: reviewers finished Mon, 13 Jul 2026 12:37:19 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3902-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3902-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3902-1 LEAHI-DD-FIRMWARE-LDT-3902_Allow DD balancing chamber switch only command to go down to 50 mL/min ]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "right now pre and post are same. make a TODO to..." Sat, 11 Jul 2026 05:38:45 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30435 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30435 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4410-3

right now pre and post are same. make a TODO to update post later

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "its mixing control interval" Sat, 11 Jul 2026 05:36:31 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30434 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30434 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4410-3

its mixing control interval

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "could you document th math behind the calculati..." Fri, 10 Jul 2026 16:49:14 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30433 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30433 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4410-3

could you document th math behind the calculation also

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: reviewers finished Fri, 10 Jul 2026 15:28:13 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4614-1 LEAHI-DD-FIRMWARE-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1: ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: reviewers finished Thu, 09 Jul 2026 15:40:26 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4733-1 LEAHI-DD-FIRMWARE-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data ]]> dd-firmware (LDT-4733-request-add-variables): LDT-4733: code review comments Thu, 09 Jul 2026 14:16:09 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=b6db00cb7b4a62957f3ce0a5c1a6d9cc5a195f6c https://devapps.diality.us/changelog/dd-firmware?cs=b6db00cb7b4a62957f3ce0a5c1a6d9cc5a195f6c Michael Garthwaite committed b6db00c on branch LDT-4733-request-add-variables in dd-firmware LDT-4733: code review comments

· /firmware/App/Monitors/Voltages.c (-7, +7) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Thu, 09 Jul 2026 14:13:11 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:22 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30396 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30396 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:14 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30395 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30395 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:10 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30394 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30394 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:06 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30393 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30393 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:02 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30392 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30392 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> dd-firmware (LDT-4733-request-add-variables): LDT-4733: code review comments Thu, 09 Jul 2026 11:21:41 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=862bea855cd392328aad1f4a93a275980ee17f26 https://devapps.diality.us/changelog/dd-firmware?cs=862bea855cd392328aad1f4a93a275980ee17f26 Michael Garthwaite committed 862bea8 on branch LDT-4733-request-add-variables in dd-firmware LDT-4733: code review comments

· /firmware/App/Monitors/Voltages.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-5, +4) | History | Source | Diff
· /firmware/App/Services/FpgaDD.h (-4, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "this would be out of scope of the original tick..." Thu, 09 Jul 2026 10:12:51 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30391 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30391 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Sean Nash "TODO?" Wed, 08 Jul 2026 14:55:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4614-1

TODO?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line" Wed, 08 Jul 2026 14:21:52 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line." Wed, 08 Jul 2026 14:20:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Please add the details what is post and pre in ..." Wed, 08 Jul 2026 13:58:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove extra line." Wed, 08 Jul 2026 14:01:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove extra line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Is this TODO still valid?" Wed, 08 Jul 2026 13:52:40 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Is this TODO still valid?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Space inside parenthesis. update across the fil..." Wed, 08 Jul 2026 13:50:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Space inside parenthesis. update across the file.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Wed, 08 Jul 2026 13:48:01 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Did you get a chance to test this alarm and unc..." Wed, 08 Jul 2026 13:45:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30382 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30382 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Did you get a chance to test this alarm and uncomment the code?

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Remove empty space." Wed, 08 Jul 2026 13:44:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30381 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30381 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Remove empty space.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "ACToDC?" Wed, 08 Jul 2026 13:44:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30380 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30380 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

ACToDC?

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Count datatype seems to be integer. Type case t..." Wed, 08 Jul 2026 13:41:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30379 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30379 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Sean Nash "Align comment. Clarify (at least in comments) ..." Wed, 08 Jul 2026 10:39:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30378 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30378 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Sean Nash "Remove extra blank lines." Wed, 08 Jul 2026 10:38:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30377 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30377 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Remove extra blank lines.

]]> dd-firmware (LDT-4733-request-add-variables): Merge branch 'staging' into LDT-4733-request-add-variables Wed, 08 Jul 2026 09:00:32 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=59fd2372fb4085d4a1c2d61a87e14313a10fd615 https://devapps.diality.us/changelog/dd-firmware?cs=59fd2372fb4085d4a1c2d61a87e14313a10fd615 Michael Garthwaite committed 59fd237 on branch LDT-4733-request-add-variables in dd-firmware Merge branch 'staging' into LDT-4733-request-add-variables

· /firmware/App/Tasks/TaskGeneral.c (-2, +5) | History | Source | Diff
]]>