Fisheye on leahi-dialin/leahi_dialin/dd/modules

leahi-dialin (LDT-4874): Changed handler debug to contain raw message and timestamp of recv

Michael Garthwaite — Mon, 13 Jul 2026 15:28:47 -0700

Michael Garthwaite committed 034ef98 on branch LDT-4874, develop, version_fix in leahi-dialin

Changed handler debug to contain raw message and timestamp of recv

· /leahi_dialin/dd/modules/alarms.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/mixing_cntrl.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-1, +1)

| History

| Source

| Diff

… 34 more files in changeset.

LEAHI-DIALIN-LDT-3735-1: reviewers finished

Mon, 13 Jul 2026 14:46:50 -0700

Tiffany Mejia and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3735-1

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

leahi-dialin (LDT-4874): Merge branch 'staging' into LDT-4874

Michael Garthwaite — Mon, 13 Jul 2026 10:33:42 -0700

Michael Garthwaite committed c4b92f4 on branch LDT-4874, develop, version_fix in leahi-dialin

Merge branch 'staging' into LDT-4874

· /leahi_dialin/dd/modules/conductivity_sensors.py	(-59, +31)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-6, +23)	\| History	\| Source	\| Diff

leahi-dialin (LDT-4874): LDT-4874: updates to td handlers for timing

Michael Garthwaite — Mon, 13 Jul 2026 10:32:42 -0700

Michael Garthwaite committed 8ad61b1 on branch LDT-4874, develop, version_fix in leahi-dialin

LDT-4874: updates to td handlers for timing

· /leahi_dialin/dd/modules/alarms.py

(-1, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-2, +5)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-1, +3)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/events.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/air_pump.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/air_trap.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/alarms.py

(-0, +19)

| History

| Source

| Diff

· /leahi_dialin/td/modules/blood_flow.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/bubble_detector.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/buttons.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/ejector.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/events.py

(-0, +3)

| History

| Source

| Diff

· /leahi_dialin/td/modules/pressure_sensors.py

(-2, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/switches.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/td/modules/syringe_pump.py

(-1, +4)

| History

| Source

| Diff

… 4 more files in changeset.

leahi-dialin (LDT-4874): LDT-4874: updates to timing for handlers

Michael Garthwaite — Mon, 13 Jul 2026 10:09:03 -0700

Michael Garthwaite committed 8ebb614 on branch LDT-4874, develop, version_fix in leahi-dialin

LDT-4874: updates to timing for handlers

· /leahi_dialin/dd/modules/alarms.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-0, +5)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/rinse_pump.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/spent_chamber_fill.py

(-0, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/substitution_pump.py

(-1, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/ultrafiltration.py

(-0, +4)

| History

| Source

| Diff

… 11 more files in changeset.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Zoltan and I had a meeting, and the counter sol..."

Behrouz NematiPour — Sun, 12 Jul 2026 23:43:02 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

LEAHI-DIALIN-LDT-4614-1: reviewers finished

Fri, 10 Jul 2026 15:28:48 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-4614-1

LEAHI-DIALIN-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:

leahi-dialin (LDT-4874): time measurement

Zoltan Miskolci — Thu, 09 Jul 2026 12:06:26 -0700

Zoltan Miskolci committed 9b516a5 on branch LDT-4874, develop, version_fix in leahi-dialin

time measurement

· /leahi_dialin/dd/modules/concentrate_pump.py	(-0, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/dialysate_pump.py	(-0, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/heaters.py	(-0, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/mixing_cntrl.py	(-0, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/temperature_sensors.py	(-0, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/voltages.py	(-1, +5)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4734-1: closed by Michael Garthwaite

Michael Garthwaite — Thu, 09 Jul 2026 11:23:37 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LDT-4734-1

LEAHI-DIALIN-LDT-4874-1: started by Dara Navaei

Dara Navaei — Thu, 09 Jul 2026 10:48:25 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4874-1

LEAHI-DIALIN-LDT-4733-1: closed by Michael Garthwaite

Michael Garthwaite — Thu, 09 Jul 2026 09:58:10 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LDT-4733-1

LEAHI-DIALIN-LDT-4733-1: reviewers finished

Wed, 08 Jul 2026 13:46:52 -0700

Vinayakam Mani , Sean Nash and Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4733-1

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data

LEAHI-DIALIN-LDT-4734-1: reviewers finished

Wed, 08 Jul 2026 10:45:48 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-4734-1

LEAHI-DIALIN-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:

LEAHI-DIALIN-LDT-4614-1: reviewers finished

Thu, 02 Jul 2026 09:54:03 -0700

Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4614-1

LEAHI-DIALIN-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:

LEAHI-DIALIN-LDT-4734-1: reviewers finished

Wed, 01 Jul 2026 20:58:33 -0700

Vendor - TEL - Sameer Poyil , Vinayakam Mani and Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4734-1

LEAHI-DIALIN-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:

LEAHI-DIALIN-LDT-4734-1: reviewers joined LEAHI-DIALIN-LDT-4734_Water Treatment and Degassin...

Wed, 01 Jul 2026 20:58:28 -0700

Vendor - TEL - Sameer Poyil joined LEAHI-DIALIN-LDT-4734-1

LEAHI-DIALIN-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:

LEAHI-DIALIN-LDT-4614-1: started by Dara Navaei

Dara Navaei — Wed, 01 Jul 2026 15:17:25 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4614-1

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "The approach of what this code does and the con..."

Zoltan Miskolci — Wed, 01 Jul 2026 14:28:52 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

LEAHI-DIALIN-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!"

Michael Garthwaite — Wed, 01 Jul 2026 15:00:14 -0700

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4734-1

fixed. thanks!

LEAHI-DIALIN-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks"

Michael Garthwaite — Wed, 01 Jul 2026 14:59:50 -0700

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4734-1

fixed. thanks

leahi-dialin (LDT-4874): LDT-4734: code review comments

Michael Garthwaite — Wed, 01 Jul 2026 14:58:27 -0700

Michael Garthwaite committed 6ce1aaa on branch LDT-4734-temp-comp-conductivity, LDT-4874 and 3 more in leahi-dialin

LDT-4734: code review comments

· /leahi_dialin/dd/modules/conductivity_sensors.py	(-0, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-0, +2)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4734-1: comment by Zoltan Miskolci "Add uncompensated conductivity to the init too"

Zoltan Miskolci — Wed, 01 Jul 2026 14:40:41 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4734-1

Add uncompensated conductivity to the init too

LEAHI-DIALIN-LDT-4734-1: comment by Zoltan Miskolci "Add uncompensated conductivity to the init too"

Zoltan Miskolci — Wed, 01 Jul 2026 14:40:29 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4734-1

Add uncompensated conductivity to the init too

leahi-dialin (LDT-4874): LDT-4734: updates to conductivity message

Michael Garthwaite — Wed, 01 Jul 2026 13:11:47 -0700

Michael Garthwaite committed 15dc2a9 on branch LDT-4734-temp-comp-conductivity, LDT-4874 and 3 more in leahi-dialin

LDT-4734: updates to conductivity message

· /leahi_dialin/common/dd_defs.py	(-3, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-0, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-14, +8)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED for now."

Behrouz NematiPour — Wed, 01 Jul 2026 12:33:22 -0700

Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

RESOLVED for now.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I would not do that because the function names ..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:32:17 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "So the same channels are used for both the Leah..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:07:36 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED."

Behrouz NematiPour — Wed, 01 Jul 2026 12:06:39 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "{code} def fp_versions(self, major: int, minor..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:05:06 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

def fp_versions(self, major: int, minor: int, micro: int, build: int,
                     fpga_id: int, fpga_major: int, fpga_minor: int, fpga_lab: int,
                     compatibility_rev: int):
     """
     Broadcasts the current dd Version Data (Msg ID: 0x0F, 15)
     Args:
         @param major: (uint) - Major version number
         @param minor: (uint) - Minor version number
         @param micro: (uint) - Micro version number
         @param build: (uint) - Build version number
         @param fpga_id: (int) - FPGA id version number
         @param fpga_major: (int) - FPGA Major version number
         @param fpga_minor: (int) - FPGA Minor version number
         @param fpga_lab: (int) - FPGA Lab version number
         @param compatibility_rev: (uint) - The FWs/UI compatibility revision
     @return: None
     """
     if not self.can_enabled:
         raise ValueError("CAN Interface is not enabled")

     payload =  conversions.unsigned_byte_to_bytearray   (major            )
     payload += conversions.unsigned_byte_to_bytearray   (minor            )
     payload += conversions.unsigned_byte_to_bytearray   (micro            )
     payload += conversions.unsigned_short_to_bytearray  (build            )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_id          )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_major       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_minor       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_lab         )
     payload += conversions.unsigned_integer_to_bytearray(compatibility_rev)

     message = CAN.CanMessage.build_message(
                                         channel_id=CAN.CanChannels.fp_sync_broadcast_ch_id,
                                         message_id=msg_ids.MsgIds.MSG_ID_FP_VERSION_RESPONSE.value,
                                         payload=payload)

     self.can_interface.send(message, 0)

leahi-dialin (LDT-4874): LDT-4734: updates to conductivity messaging.

Michael Garthwaite — Wed, 01 Jul 2026 10:30:06 -0700

Michael Garthwaite committed ed3eb12 on branch LDT-4734-temp-comp-conductivity, LDT-4874 and 3 more in leahi-dialin

LDT-4734: updates to conductivity messaging.

· /leahi_dialin/common/dd_defs.py	(-5, +7)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-59, +22)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-6, +27)	\| History	\| Source	\| Diff