My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

you need to bring in the new set of valves here as well.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

Align the indent. Replace RO to FP.

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Same question as above: should we alarm if the retries failed?

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

If a retry goes wrong will you trigger an alarm?

Any fault alarm here?

Have these variables been initialized correctly?

Remove extra blank line.

We generally don't add { } to switch cases unless they require local variable declarations.

If we're not including a timestamp, can we just remove this line of code?

Why commented out?

Remove blank line.

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).