· /firmware/App/Controllers/Valves.c

(-0, +2)

| History

| Source

| Diff

]]> Fri, 31 Jul 2026 11:24:40 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=732ceedff09ef5d99a5972b934c499ea9e97a9ca https://devapps.diality.us/changelog/td-firmware?cs=732ceedff09ef5d99a5972b934c499ea9e97a9ca Dara Navaei committed 732ceed on branch LDT-4063-power-control-and-post---fw-imp, LDT-4072-power-loss---fw-implementation- and 4 more in td-firmware Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

· /firmware/App/TDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Fri, 31 Jul 2026 11:09:47 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4031-1/#c30977 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4031-1/#c30977 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4031-1

While you are updating this file, can please break this line?

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );

Add to inputs: preTreatmentStatePublishInterval

and break the line

assign result to a variable and then return and break the line

break this line

input is none

break this line

assign this to a variable and then return the variable.

break this line

Can we align = from line 270 to 281?

break lines of this function to match our standard of 100 columns.

break lines of this function to match our standard of 100 columns.

input is none

can we define this as NUM_OF_BATTERY_REGISTERS = BATTERY_END_OF_LIST_TIME_TO_PUBLISH,

and use NUM_OF_BATTERY_REGISTERS everywhere instead of using [ NUM_OF_BATTERY_REGISTERS - 1 ]

break this line

align all the comments to line 57

Add Comments for line 43 to 50 and align all the comments of this section to line 38.

add a blank line above

add a blank line above

Add space in [registerSel]

break this line

add a blank line above

break this line