Fisheye on leahi-dialin/leahi_dialin/dd/modules/drybicart.py

LEAHI-DIALIN-LDT-5186-1: comment by Zoltan Miskolci "indent"

Zoltan Miskolci — Fri, 14 Aug 2026 08:29:14 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-5186-1

indent

LEAHI-DIALIN-LDT-5186-1: comment by Zoltan Miskolci "indent"

Zoltan Miskolci — Fri, 14 Aug 2026 08:29:02 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-5186-1

indent

LEAHI-DIALIN-LDT-5186-1: comment by Raghu Kallala "are we missing any value in (). If not remove t..."

Raghu Kallala — Wed, 12 Aug 2026 12:32:12 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5186-1

are we missing any value in (). If not remove the (
Same in line 298

LEAHI-DIALIN-LDT-5186-1: comment by Raghu Kallala "Please reserve the IDs in the shared excel and ..."

Raghu Kallala — Wed, 12 Aug 2026 12:27:34 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5186-1

Please reserve the IDs in the shared excel and use the available IDs

LEAHI-DIALIN-LDT-5152-1: closed by Zoltan Miskolci

Zoltan Miskolci — Tue, 11 Aug 2026 09:34:58 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-2004-3: started by Dara Navaei

Dara Navaei — Mon, 10 Aug 2026 17:18:26 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-2004-3

LEAHI-DIALIN-LDT-5152-1: comment by Zoltan Miskolci "I think that's what is usually shown, the first..."

Zoltan Miskolci — Mon, 10 Aug 2026 15:35:30 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5152-1

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

LEAHI-DIALIN-LDT-5152-1: reviewers finished

Mon, 10 Aug 2026 15:07:00 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor

LEAHI-DIALIN-LDT-5152-1: comment by Raghu Kallala "Was it a regulatory requirement before to have ..."

Raghu Kallala — Mon, 10 Aug 2026 14:29:02 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5152-1

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

LEAHI-DIALIN-LDT-5152-1: comment by Zoltan Miskolci "No need, in a different CR I have a module that..."

Zoltan Miskolci — Fri, 07 Aug 2026 15:48:20 -0700

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-5152-1

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

LEAHI-DIALIN-LDT-5152-1: reviewers finished

Thu, 06 Aug 2026 22:21:37 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor

LEAHI-DIALIN-LDT-5152-1: comment by Michael Garthwaite "In FW we pre-populated Alarm IDs up to 300 to h..."

Michael Garthwaite — Thu, 06 Aug 2026 22:08:47 -0700

Michael Garthwaite commented on LEAHI-DIALIN-LDT-5152-1

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

leahi-dialin (LDT-5205-dd_nvm_update): - refactored DD modules

Zoltan Miskolci — Wed, 29 Jul 2026 12:26:45 -0700

Zoltan Miskolci committed eca9e15 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

- refactored DD modules

· /leahi_dialin/common/dd_defs.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-27, +41)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-31, +191)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-10, +69)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-33, +65)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-16, +39)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/mixing_cntrl.py

(-46, +242)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-4, +25)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-18, +98)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-12, +26)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/rinse_pump.py

(-8, +49)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/spent_chamber_fill.py

(-8, +49)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/substitution_pump.py

(-14, +27)

| History

| Source

| Diff

… 4 more files in changeset.

leahi-dialin (LDT-5205-dd_nvm_update): Refactor changes #1

Zoltan Miskolci — Tue, 21 Jul 2026 09:13:52 -0700

Zoltan Miskolci committed 3f4937e on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

Refactor changes #1

· /leahi_dialin/common/msg_defs.py

(-152, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-142, +109)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/mixing_cntrl.py

(-1, +1)

| History

| Source

| Diff

… 49 more files in changeset.

LEAHI-DIALIN-LDT-5152-1: started by Dara Navaei

Dara Navaei — Mon, 20 Jul 2026 12:34:32 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5186-1: started by Dara Navaei

Dara Navaei — Mon, 20 Jul 2026 04:02:36 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5186-1

LEAHI-DIALIN-LDT-4874-1: started by Dara Navaei

Dara Navaei — Thu, 09 Jul 2026 10:48:25 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4874-1

LEAHI-DIALIN-LDT-4612-3: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 25 Jun 2026 16:13:31 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-4612-3

LEAHI-DIALIN-LDT-4612-3: reviewers finished

Thu, 25 Jun 2026 16:13:02 -0700

Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4612-3

LEAHI-DIALIN-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:

LEAHI-DIALIN-LDT-4612-3: reviewers finished

Wed, 24 Jun 2026 21:23:29 -0700

Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-4612-3

LEAHI-DIALIN-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:

LEAHI-DIALIN-LDT-4612-3: comment by Vinayakam Mani "Update the name."

Vinayakam Mani — Wed, 24 Jun 2026 14:56:21 -0700

Vinayakam Mani commented on LEAHI-DIALIN-LDT-4612-3

Update the name.

leahi-dialin (LDT-4410-dialysate-composition-mixing---): LDT-4612 dialin updates for mixing conrol and dry bicart

Vendor - TEL - Sameer Poyil — Wed, 24 Jun 2026 14:33:51 -0700

Vendor - TEL - Sameer Poyil committed 4fc29ae on branch LDT-3735-non-volatile-memory, LDT-4410-dialysate-composition-mixing--- and 34 more in leahi-dialin

LDT-4612 dialin updates for mixing conrol and dry bicart

· /leahi_dialin/common/msg_ids.py	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-0, +23)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/mixing_cntrl.py	(-65, +67)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4612-3: comment by Zoltan Miskolci "If it's mixing control, then rename the paramet..."

Zoltan Miskolci — Thu, 18 Jun 2026 14:35:54 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4612-3

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

LEAHI-DIALIN-LDT-4612-3: comment by Zoltan Miskolci "Fix Spacing please to be consistent with the re..."

Zoltan Miskolci — Thu, 18 Jun 2026 14:34:54 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4612-3

Fix Spacing please to be consistent with the rest of the variables

LEAHI-DIALIN-LDT-4612-3: comment by Zoltan Miskolci "Please maintain the FW-SW Integration.xlsx for ..."

Zoltan Miskolci — Thu, 18 Jun 2026 14:33:54 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4612-3

Please maintain the FW-SW Integration.xlsx for MSG_ID reservation.
Meaning, add these there too to avoid overwriting or deleting them

leahi-dialin (LDT-4410-dialysate-composition-mixing---): LDT-4612 -dialin updates for mixing control

Vendor - TEL - Sameer Poyil — Thu, 18 Jun 2026 12:54:12 -0700

Vendor - TEL - Sameer Poyil committed b00b17d on branch LDT-3735-non-volatile-memory, LDT-4410-dialysate-composition-mixing--- and 34 more in leahi-dialin

LDT-4612 -dialin updates for mixing control

· /leahi_dialin/common/msg_ids.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/mixing_cntrl.py	(-5, +7)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4612-3: started by Dara Navaei

Dara Navaei — Wed, 17 Jun 2026 18:48:06 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4612-3

LEAHI-DIALIN-LDT-4721-1: closed by Zoltan Miskolci

Zoltan Miskolci — Tue, 16 Jun 2026 09:53:10 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-4721-1

LEAHI-DIALIN-LDT-4612-1: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Tue, 16 Jun 2026 07:40:58 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-4612-1

leahi-dialin (LDT-4410-dialysate-composition-mixing---): Merge branch 'LDT-4721-extra_param' into staging

Zoltan Miskolci — Mon, 15 Jun 2026 16:37:30 -0700

Zoltan Miskolci committed 78b7d4b on branch LDT-3735-non-volatile-memory, LDT-4072-power-loss and 39 more in leahi-dialin

Merge branch 'LDT-4721-extra_param' into staging

· /leahi_dialin/dd/modules/drybicart.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-4, +9)	\| History	\| Source	\| Diff