· /firmware/App/Controllers/Heaters.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.h	(-2, +2)	| History	| Source	| Diff

]]> Thu, 20 Aug 2026 13:32:34 -0700 Vendor - TEL - Suresh Dharnala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 Vendor - TEL - Suresh Dharnala Closed LEAHI-DD-FIRMWARE-LDT-4049-1 ]]> Thu, 20 Aug 2026 11:50:49 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 Michael Garthwaite and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4049-1 LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2: ]]> Wed, 19 Aug 2026 13:40:17 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c31510 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c31510 Michael Garthwaite commented on LEAHI-DD-FIRMWARE-LDT-4049-1

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

I'm seeing a lot of magic numbers. We should have #defines for these values.

Add doxygen comments to right.

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

removed

updated

updated

updated

removed

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-0, +89)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.h	(-0, +3)	| History	| Source	| Diff

]]> Wed, 12 Aug 2026 15:59:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5409-1/#c31283 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5409-1/#c31283 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-5409-1

Are we done testing? Can we remote test variables and code?

Remove Sequence step states if not being used.

Update comments ( remove start/end states)

Update TD to DD.

Update alarm properties (DD fault, Priority eti,.)

Remove the empty line.

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Remove commented code.

Remove D34 valve close.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

void inside paranthesis.

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that this function will check the condition and skip the valves actions if not met. this is not the expected behavior.

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

Open D80, not D85.

Remove the commented code.

Update description across the file.