Fisheye on leahi-dialin/leahi_dialin/fp/modules/constants.py

LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 22 Jan 2026 10:07:41 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Wed, 21 Jan 2026 12:35:59 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u...

Wed, 21 Jan 2026 09:47:38 -0800

Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Tue, 20 Jan 2026 15:33:25 -0800

Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: comment by Zoltan Miskolci "Putting the aliases at the end makes them group..."

Zoltan Miskolci — Mon, 12 Jan 2026 17:07:56 -0800

Zoltan Miskolci replied to Sean Nash in LEAHI-DIALIN-LDT-3214-1

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

LEAHI-DIALIN-LDT-3214-1: comment by Sean Nash "Why move this here? Seems like an odd placemen..."

Sean Nash — Mon, 12 Jan 2026 13:04:02 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-3214-1

Why move this here? Seems like an odd placement so far away from D14.

LEAHI-DIALIN-LDT-3214-1: started by Dara Navaei

Dara Navaei — Tue, 06 Jan 2026 16:33:01 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:33:43 -0800

Dara Navaei Needs Fixing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:33:39 -0800

Dara Navaei Abandoned LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-237-1: closed by Behrouz NematiPour

Behrouz NematiPour — Thu, 24 Apr 2025 16:04:58 -0700

Behrouz NematiPour Closed LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237-1: reviewers finished

Thu, 24 Apr 2025 16:04:25 -0700

Dara Navaei finished reviewing LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237 - Simulator Dialin

LEAHI-DIALIN-LEAH-261-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 23 Apr 2025 16:29:37 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LDT-237-1: reviewers finished

Wed, 23 Apr 2025 16:15:22 -0700

Tiffany Mejia and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237 - Simulator Dialin

LEAHI-DIALIN-LEAH-261-1: reviewers finished

Wed, 23 Apr 2025 16:02:54 -0700

Tiffany Mejia and Sean Nash finished reviewing LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LEAH-261_FW RO Flow Sensor Driver

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): test

Behrouz NematiPour — Wed, 23 Apr 2025 15:49:25 -0700

Behrouz NematiPour committed 1a719e5 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 88 more in leahi-dialin

test

· /leahi_dialin/fp/__init__.py

(-0, +22)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +255)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-0, +230)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/constants.py

(-0, +18)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/flow_sensors.py

(-0, +175)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/levels.py

(-0, +128)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/pressure_sensors.py

(-0, +220)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/valves.py

(-0, +294)

| History

| Source

| Diff

· /leahi_dialin/fp/reverse_osmosis.py

(-0, +248)

| History

| Source

| Diff

· /leahi_dialin/ro/__init__.py

(-22, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/boost_pump.py

(-255, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/conductivity_sensors.py

(-230, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/constants.py

(-18, +0)

| History

| Source

| Diff

… 5 more files in changeset.

LEAHI-DIALIN-LEAH-261-1: started by Michael Garthwaite

Michael Garthwaite — Wed, 23 Apr 2025 15:16:55 -0700

Michael Garthwaite started review LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LDT-237-1: reviewers removed from LEAHI-DIALIN-LDT-237 - Simulator Dialin

Wed, 23 Apr 2025 14:46:59 -0700

Behrouz NematiPour removed amanesh (deleted user) from LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237 - Simulator Dialin

LEAHI-DIALIN-LEAH-261-1: comment by Michael Garthwaite "fixed. Thanks!"

Michael Garthwaite — Wed, 23 Apr 2025 14:26:07 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-261-1

fixed. Thanks!

LEAHI-DIALIN-LDT-237-1: started by Dara Navaei

Dara Navaei — Sat, 05 Apr 2025 20:18:19 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "Remove extra blank line."

Sean Nash — Mon, 24 Feb 2025 09:49:44 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

Remove extra blank line.

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "function header?"

Sean Nash — Mon, 24 Feb 2025 09:47:55 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

function header?

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "We should remove DG references throughout. If ..."

Sean Nash — Mon, 24 Feb 2025 09:44:39 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): WIP on develop...

Michael Garthwaite — Fri, 21 Feb 2025 08:23:54 -0800

Michael Garthwaite committed 0f08c28 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 88 more in leahi-dialin

WIP on develop

Renamed RO class and sub modules to use FP to be in line with sub system names

· /leahi_dialin/__init__.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/fp/__init__.py

(-0, +1)

| History

| Source

· /leahi_dialin/fp/filtration_purification.py

(-0, +250)

| History

| Source

· /leahi_dialin/fp/modules/__init__.py

(-0, +0)

| History

| Source

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +256)

| History

| Source

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-0, +230)

| History

| Source

· /leahi_dialin/fp/modules/constants.py

(-0, +18)

| History

| Source

· /leahi_dialin/fp/modules/flow_sensors.py

(-0, +175)

| History

| Source

· /leahi_dialin/fp/modules/levels.py

(-0, +135)

| History

| Source

· /leahi_dialin/fp/modules/pressure_sensors.py

(-0, +220)

| History

| Source

· /leahi_dialin/fp/modules/valves.py

(-0, +294)

| History

| Source

· /leahi_dialin/protocols/CAN.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/ro/__init__.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/boost_pump.py

(-255, +0)

| History

| Source

| Diff

… 9 more files in changeset.

LEAHI-DIALIN-LEAH-261-1: started by Dara Navaei

Dara Navaei — Fri, 14 Feb 2025 09:26:45 -0800

Dara Navaei started review LEAHI-DIALIN-LEAH-261-1