LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

closed on 22 Jan

Author

Moderator

Reviewers

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 82

leahi-dialin 0
- Folder leahi_dialin 0
  - Folder common 0
    - File dd_defs.py 2 Remove
    - File fp_defs.py 0 Remove
    - File msg_ids.py 0 Remove
    - File override_templates.py 0 Remove
    - File td_defs.py 0 Remove
    - File test_config_defs.py 0 Remove
  - Folder dd 0
    - Folder modules 0
      - File alarms.py 0 Remove
      - File balancing_chamber.py 0 Remove
      - File blood_leak.py 0 Remove
      - File concentrate_pump.py 0 Remove
      - File conductivity_sensors.py 0 Remove
      - File constants.py 0 Remove
      - File dd_test_configs.py 0 Remove
      - File dialysate_pump.py 0 Remove
      - File events.py 0 Remove
      - File gen_dialysate.py 0 Remove
      - File heaters.py 0 Remove
      - File levels.py 0 Remove
      - File post_gen_dialysate.py 0 Remove
      - File pre_gen_dialysate.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File rinse_pump.py 0 Remove
      - File spent_chamber_fill.py 0 Remove
      - File temperature_sensors.py 0 Remove
      - File ultrafiltration.py 0 Remove
      - File valves.py 0 Remove
      - File voltages.py 0 Remove
    - Folder proxies 0
      - File ro_proxy.py 0 Remove
      - File td_proxy.py 0 Remove
    - File dialysate_delivery.py 0 Remove
  - Folder fp 0
    - Folder modules 0
      - File alarms.py 0 Remove
      - File boost_pump.py 0 Remove
      - File conductivity_sensors.py 0 Remove
      - File constants.py 0 Remove
      - File events.py 0 Remove
      - File flow_sensors.py 0 Remove
      - File fp_test_configs.py 0 Remove
      - File levels.py 0 Remove
      - File permeate_tank.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File ro_pump.py 0 Remove
      - File temperatures.py 0 Remove
      - File valves.py 0 Remove
      - File water_pumps.py 0 Remove
    - Folder proxies 0
      - File dd_proxy.py 0 Remove
    - File filtration_purification.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder td 0
    - Folder modules 0
      - File air_pump.py 0 Remove
      - File air_trap.py 0 Remove
      - File alarms.py 0 Remove
      - File blood_flow.py 0 Remove
      - File bubble_detector.py 0 Remove
      - File buttons.py 0 Remove
      - File constants.py 0 Remove
      - File ejector.py 0 Remove
      - File events.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File switches.py 0 Remove
      - File td_test_configs.py 0 Remove
      - File temperature_sensors.py 0 Remove
      - File treatment.py 0 Remove
      - File valves.py 0 Remove
      - File voltages.py 0 Remove
    - Folder proxies 0
      - File dd_proxy.py 0 Remove
      - File ui_proxy.py 0 Remove
    - File treatment_delivery.py 0 Remove
  - Folder ui 0
    - File dd_messaging.py 0 Remove
    - File td_messaging.py 0 Remove
    - File td_messaging_alarms.py 0 Remove
  - Folder utils 0
    - File base.py 0 Remove
    - File checks.py 0 Remove
    - File data_logger.py 0 Remove
    - File helpers.py 0 Remove
    - File nv_ops_utils.py 0 Remove
- Folder tests 0
  - Folder data_capture_helpers 0
    - File fp_helpers.py 0 Remove
  - Folder depreciated_tests 0
    - File hd_test_pumps_open_loop.py 0 Remove
    - File test_flush.py 0 Remove
  - Folder peter 0
    - File test_gen_requirements.py 0 Remove
    - File test_hd_records.py 0 Remove
  - File DebugMsgCatcher.py 0 Remove
- Folder tools 0
  - File build_common_defs.py 0 Remove
- File .gitignore 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Zoltan Miskolci	Author & Moderator	11m	1	Putting the aliases at the end makes them grouped up and ...
Sean Nash	Reviewer - Complete	27m	1	Why move this here? Seems like an odd placement so far aw...
Nicholas Ramirez	Reviewer - 0% reviewed
Stephen Quong	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - Complete	39m
Behrouz NematiPour	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 1% reviewed	2m
Michael Garthwaite	Reviewer - 0% reviewed	6m
Vinayakam Mani	Reviewer - 0% reviewed
Raghu Kallala	Reviewer - 4% reviewed	7m
Total		1h 36m	2

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override...

LEAHI-DIALIN-LDT-3214-1 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override...

LEAHI-DIALIN-LDT-3214-1 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time