Fisheye on dd-firmware/firmware/App/Services https://devapps.diality.us/changelog/~br%3DLDT-948-unit-testing-dd-fwcommon-testcas/dd-firmware/firmware/App/Services Recent activity in "dd-firmware" under directory /firmware/App/Services LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Declare local variables at top of scope." Sun, 26 Apr 2026 12:36:19 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28651 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28651 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Declare local variables at top of scope.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Add space between ( and ?" Sun, 26 Apr 2026 12:34:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28650 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28650 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Add space between ( and ?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line." Sun, 26 Apr 2026 12:33:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28649 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28649 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Why redeclare result?" Sun, 26 Apr 2026 12:31:45 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28648 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28648 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Why redeclare result?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line." Sun, 26 Apr 2026 12:31:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28647 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28647 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Why are you redeclaring result? This assignmen..." Sun, 26 Apr 2026 12:30:57 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28646 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28646 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Why are you redeclaring result? This assignment will not survive outside of the if statement.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line." Sun, 26 Apr 2026 12:30:04 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28645 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28645 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line." Sun, 26 Apr 2026 12:29:45 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28644 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28644 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers resumed Fri, 24 Apr 2026 22:17:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: closed by Raghu Kallala Wed, 22 Apr 2026 10:41:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers finished Wed, 22 Apr 2026 09:55:43 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers finished Tue, 21 Apr 2026 14:17:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Raghu Kallala "Updated" Tue, 21 Apr 2026 08:34:00 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

Updated

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: closed by Vendor - TEL - Sameer Poyil Mon, 20 Apr 2026 08:17:53 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: closed by Vinayakam Mani Fri, 17 Apr 2026 09:54:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3352-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: reviewers finished Thu, 16 Apr 2026 23:17:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-9 LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Sean Nash Thu, 16 Apr 2026 23:13:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Vendor - TEL - Sameer Poyil Thu, 16 Apr 2026 16:23:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its static function and not used by external AP..." Thu, 16 Apr 2026 14:28:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]>