Done.

Done

Done.

Same comment.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Input is d78TempAvgC

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Not sure these min/max are right here either.

Done.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Done.

Done.

Done.

Remove extra blank line.

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

Remove blank line.

Done.

Done.

mis aligned ?

mis aligned ?

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

its a reverse logic - is it OK to make positive instead of not defined ?

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

Resolve merge conflicts.

Add blank line between declarations and rest of code.

Add comment to right listing which math functions we're using.