The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

You are right, modified in all places

FALSE?

FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

Add comment that these modes not (yet?) supported.

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

Updated

Fixed

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

Remove blank line.

Thanks. Resolved

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

Where did this valve enum go?

Done.

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if still any specific alarms triggers, will try to disable those alarms.

2 blank lines above and below test support banners.