Fisheye on ro-firmware/firmware/source https://devapps.diality.us/changelog/~br%3DLEAH-1972-ro-integration-changes-1/ro-firmware/firmware/source Recent activity in "ro-firmware" under directory /firmware/source LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-1928-3: closed by Raghu Kallala Tue, 02 Sep 2025 11:08:30 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3 https://devapps.diality.us/cru/RO-LDT-1928-3 Raghu Kallala Closed RO-LDT-1928-3 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-1928-3: reviewers finished Thu, 28 Aug 2025 14:17:51 -0700 https://devapps.diality.us/cru/RO-LDT-1928-3 https://devapps.diality.us/cru/RO-LDT-1928-3 Michael Garthwaite and Sean Nash finished reviewing RO-LDT-1928-3 RO-LDT-1928_Inlet Pressure Check ST ]]> RO-LDT-1928-3: comment by Raghu Kallala "Calling it regardless of hardware" Thu, 28 Aug 2025 13:40:47 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23955 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23955 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Calling it regardless of hardware

]]> RO-LDT-1928-3: comment by Sean Nash "Follow up with Eliza on TODO question." Wed, 27 Aug 2025 13:54:28 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23908 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23908 Sean Nash commented on RO-LDT-1928-3

Follow up with Eliza on TODO question.

]]> RO-LDT-1928-3: comment by Raghu Kallala "Pushed the commit" Wed, 27 Aug 2025 08:14:10 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23899 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23899 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Pushed the commit

]]> RO-LDT-1928-3: comment by Raghu Kallala "Done" Wed, 27 Aug 2025 08:12:50 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23898 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23898 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Done

]]> RO-LDT-1928-3: comment by Raghu Kallala "Done" Wed, 27 Aug 2025 08:12:45 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23897 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23897 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Done

]]> RO-LDT-1928-3: comment by Sean Nash "Looks like it's still here." Tue, 26 Aug 2025 13:38:29 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23874 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23874 Sean Nash replied to Raghu Kallala in RO-LDT-1928-3

Looks like it's still here.

]]> RO-LDT-1928-3: comment by Michael Garthwaite "Current builds of the FP are not triggering ala..." Mon, 25 Aug 2025 15:05:55 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1928-3/#c23861 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23861 Michael Garthwaite replied to Sean Nash in RO-LDT-1928-3

Current builds of the FP are not triggering alarms. Alarms and recovery states ( ex: paused states ) will be implemented and covered in https://diality.atlassian.net/browse/LDT-828 once requirement draft is finalized.

]]> RO-LDT-1928-3: comment by Sean Nash "If in paused state due to alarm, if alarm is re..." Thu, 21 Aug 2025 09:20:18 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23847 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23847 Sean Nash replied to Raghu Kallala in RO-LDT-1928-3

If in paused state due to alarm, if alarm is recoverable we would need a way to go back to in progress state when user clears alarm.

]]> RO-LDT-1928-3: comment by Raghu Kallala "Done." Wed, 20 Aug 2025 10:00:56 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23846 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23846 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Done.

]]> RO-LDT-1928-3: comment by Raghu Kallala "Yeah, I agree. We can remove it" Wed, 20 Aug 2025 09:58:26 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23845 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23845 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Yeah, I agree.
We can remove it

]]> RO-LDT-1928-3: comment by Raghu Kallala "Yes, will be in paused state, until we do the P..." Wed, 20 Aug 2025 09:57:52 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23844 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23844 Raghu Kallala replied to Sean Nash in RO-LDT-1928-3

Yes, will be in paused state, until we do the PreGen mode again.

]]> RO-LDT-1928-3: comment by Sean Nash "If check completed, are we stuck in this state ..." Tue, 19 Aug 2025 14:05:32 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23838 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23838 Sean Nash commented on RO-LDT-1928-3

If check completed, are we stuck in this state forever?

]]> RO-LDT-1928-3: comment by Sean Nash "Is this assignment needed? Seems like it would..." Tue, 19 Aug 2025 14:03:31 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23837 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23837 Sean Nash commented on RO-LDT-1928-3

Is this assignment needed? Seems like it would already have to be FALSE to get into the if.

]]> RO-LDT-1928-3: comment by Sean Nash "Align comments." Tue, 19 Aug 2025 13:33:36 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23836 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23836 Sean Nash commented on RO-LDT-1928-3

Align comments.

]]> RO-LDT-1928-3: comment by Sean Nash "Add a blank line before group end marker." Tue, 19 Aug 2025 13:33:06 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23835 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23835 Sean Nash commented on RO-LDT-1928-3

Add a blank line before group end marker.

]]> RO-LDT-1928-3: comment by Sean Nash "Align comments or remove them (not necessary fo..." Tue, 19 Aug 2025 13:32:48 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1928-3/#c23834 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23834 Sean Nash commented on RO-LDT-1928-3

Align comments or remove them (not necessary for function prototypes).

]]> RO-LDT-1928-3: comment by Raghu Kallala "Removed." Tue, 19 Aug 2025 10:23:47 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23832 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23832 Raghu Kallala replied to Michael Garthwaite in RO-LDT-1928-3

Removed.

]]> RO-LDT-1928-3: comment by Raghu Kallala "Removed." Tue, 19 Aug 2025 10:23:38 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23831 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23831 Raghu Kallala replied to Michael Garthwaite in RO-LDT-1928-3

Removed.

]]> RO-LDT-1928-3: comment by Raghu Kallala "Removed." Tue, 19 Aug 2025 10:23:27 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23830 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23830 Raghu Kallala replied to Michael Garthwaite in RO-LDT-1928-3

Removed.

]]> RO-LDT-1928-3: comment by Raghu Kallala "Updated, thanks." Tue, 19 Aug 2025 10:23:14 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1928-3/#c23829 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23829 Raghu Kallala replied to Michael Garthwaite in RO-LDT-1928-3

Updated, thanks.

]]> RO-LDT-1928-3: comment by Michael Garthwaite "Dont think we will need to control the permeate..." Mon, 18 Aug 2025 09:05:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1928-3/#c23795 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23795 Michael Garthwaite commented on RO-LDT-1928-3

Dont think we will need to control the permeate tank in this state

]]> RO-LDT-1928-3: comment by Michael Garthwaite "Please remove unnecessary #include's like ROPum..." Mon, 18 Aug 2025 09:04:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1928-3/#c23794 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23794 Michael Garthwaite commented on RO-LDT-1928-3

Please remove unnecessary #include's like ROPump, PermeateTank, Conductivity, etc.

]]> RO-LDT-1928-3: comment by Michael Garthwaite "Remove commented function header." Mon, 18 Aug 2025 09:02:28 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1928-3/#c23793 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23793 Michael Garthwaite commented on RO-LDT-1928-3

Remove commented function header.

]]> RO-LDT-1928-3: comment by Michael Garthwaite "Similar to how we have the if statement above, ..." Mon, 18 Aug 2025 09:01:08 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1928-3/#c23792 https://devapps.diality.us/cru/RO-LDT-1928-3/#c23792 Michael Garthwaite commented on RO-LDT-1928-3

Similar to how we have the if statement above, please assign the state to FP_PRE_GENP_FILTER_FLUSH once we complete the pressure check.

]]>