Fisheye on dd-firmware/firmware/App/Drivers/BalancingChamber.c https://devapps.diality.us/changelog/~br%3DLEAH-224-fw-dd-gear-pump-driver-1/dd-firmware/firmware/App/Drivers/BalancingChamber.c Recent activity in "dd-firmware" under directory /firmware/App/Drivers/BalancingChamber.c LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> DD-LEAH-1971-1: closed by Vinayakam Mani Tue, 04 Feb 2025 11:39:42 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1 https://devapps.diality.us/cru/DD-LEAH-1971-1 Vinayakam Mani Closed DD-LEAH-1971-1 ]]> DD-LEAH-1971-1: reviewers finished Mon, 03 Feb 2025 10:58:07 -0800 https://devapps.diality.us/cru/DD-LEAH-1971-1 https://devapps.diality.us/cru/DD-LEAH-1971-1 Michael Garthwaite finished reviewing DD-LEAH-1971-1 DD-LEAH-1971_DD Integration Changes ]]> DD-LEAH-1971-1: reviewers finished Thu, 30 Jan 2025 10:23:09 -0800 https://devapps.diality.us/cru/DD-LEAH-1971-1 https://devapps.diality.us/cru/DD-LEAH-1971-1 Sean Nash finished reviewing DD-LEAH-1971-1 DD-LEAH-1971_DD Integration Changes ]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done" Wed, 29 Jan 2025 17:46:16 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21297 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21297 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Wed, 29 Jan 2025 17:45:59 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21296 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21296 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Wed, 29 Jan 2025 17:29:31 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21293 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21293 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Sean Nash "Add a blank line between function and end group..." Wed, 29 Jan 2025 13:30:11 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21261 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21261 Sean Nash commented on DD-LEAH-1971-1

Add a blank line between function and end group marker.

]]> DD-LEAH-1971-1: comment by Sean Nash "I guess my point was about more than the commen..." Wed, 29 Jan 2025 13:24:06 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21260 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21260 Sean Nash replied to Vinayakam Mani in DD-LEAH-1971-1

I guess my point was about more than the comment. Can we test the default case in vectorcast? I think we can and so we should remove the #ifndef.

]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): Refactoring Code review comments fix Tue, 28 Jan 2025 17:21:29 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=322747d530c1b8205be257557e53dcfe9caad50a https://devapps.diality.us/changelog/dd-firmware?cs=322747d530c1b8205be257557e53dcfe9caad50a Vinayakam Mani committed 322747d on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 108 more in dd-firmware Refactoring Code review comments fix

· /firmware/App/Controllers/ConcentratePumps.c (-59, +55) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-15, +17) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.h (-3, +6) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-49, +37) | History | Source | Diff
· /firmware/App/Controllers/PistonPumpControl.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/PistonPumpControl.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-5, +0) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +0) | History | Source | Diff
· /firmware/App/DDCommon.h (-3, +6) | History | Source | Diff
· /firmware/App/Drivers/BalancingChamber.c (-790, +0) | History | Source | Diff
· /firmware/App/Drivers/BalancingChamber.h (-74, +0) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-2, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-5, +4) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-79, +46) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.h (-2, +2) | History | Source | Diff
… 8 more files in changeset.
]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 17:10:27 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21259 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21259 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 17:01:17 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21258 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21258 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:53:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21257 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21257 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "This is unused for now. Initially we assumed fl..." Tue, 28 Jan 2025 16:50:59 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21256 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21256 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

This is unused for now. Initially we assumed floater has two outputs (floater 1 and floater 2) and created these routines. may be removed once FPGA cleanup is done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:48:12 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21255 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21255 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:41:46 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21254 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21254 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Reserved." Tue, 28 Jan 2025 16:35:15 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21253 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21253 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Reserved.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Yeap. will remove once we identify the UF pumps..." Tue, 28 Jan 2025 16:33:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21252 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21252 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Yeap. will remove once we identify the UF pumps.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done" Tue, 28 Jan 2025 16:32:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21251 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21251 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:29:00 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21250 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21250 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:27:33 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21249 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21249 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:26:24 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21248 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21248 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 16:24:13 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21247 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21247 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done" Tue, 28 Jan 2025 16:14:44 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21246 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21246 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done" Tue, 28 Jan 2025 16:14:38 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21245 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21245 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 15:50:22 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21244 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21244 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Removed." Tue, 28 Jan 2025 15:45:40 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21243 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21243 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Removed.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Done." Tue, 28 Jan 2025 15:45:00 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21242 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21242 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Done.

]]> DD-LEAH-1971-1: comment by Vinayakam Mani "Same as above." Tue, 28 Jan 2025 15:30:35 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21241 https://devapps.diality.us/cru/DD-LEAH-1971-1/#c21241 Vinayakam Mani replied to Sean Nash in DD-LEAH-1971-1

Same as above.

]]>