DD-LEAH-1971-1 DD-LEAH-1971_DD Integration Changes

closed on 04 Feb

Author

Moderator

Reviewers

DD-LEAH-1971_DD Integration Changes

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 53

dd-firmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Controllers 0
      - File BalancingChamber.c 0 Remove
      - File BalancingChamber.h 0 Remove
      - File ConcentratePumps.c 18 Remove
      - File ConcentratePumps.h 0 Remove
      - File DialysatePumps.c 26 Remove
      - File DialysatePumps.h 0 Remove
      - File Heaters.c 2 Remove
      - File Heaters.h 0 Remove
      - File PistonPumpControl.c 4 Remove
      - File PistonPumpControl.h 2 Remove
      - File Valves.c 2 Remove
      - File Valves.h 2 Remove
    - Folder Drivers 0
      - File BalancingChamber.c 0 Remove
      - File BalancingChamber.h 0 Remove
      - File ConductivitySensors.c 0 Remove
      - File ConductivitySensors.h 0 Remove
      - File InternalADC.c 0 Remove
      - File InternalADC.h 0 Remove
      - File PressureSensor.c 2 Remove
      - File PressureSensor.h 0 Remove
      - File TemperatureSensors.c 6 Remove
      - File TemperatureSensors.h 0 Remove
    - Folder Modes 0
      - File BalancingChamber.c 0 Remove
      - File BalancingChamber.h 0 Remove
      - File ModeFault.c 0 Remove
      - File ModeGenDialysate.c 22 Remove
      - File ModeGenDialysate.h 0 Remove
      - File ModeInitPOST.c 0 Remove
      - File ModeStandby.c 6 Remove
      - File ModeStandby.h 0 Remove
    - Folder Monitors 0
      - File Conductivity.c 0 Remove
      - File Conductivity.h 0 Remove
      - File Level.c 4 Remove
      - File Level.h 0 Remove
      - File Pressure.c 0 Remove
      - File Pressure.h 0 Remove
      - File Temperature.c 0 Remove
      - File Temperature.h 0 Remove
    - Folder Services 0
      - File AlarmMgmtDD.c 0 Remove
      - File AlarmMgmtSWFaults.h 2 Remove
      - File FpgaDD.c 24 Remove
      - File FpgaDD.h 2 Remove
      - File Messaging.c 2 Remove
      - File TDInterface.c 0 Remove
      - File TDInterface.h 2 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 0 Remove
      - File TaskPriority.c 0 Remove
    - File DDCommon.h 0 Remove
  - Folder include 0
    - File can.h 0 Remove
  - Folder source 0
    - File adc.c 0 Remove
    - File can.c 0 Remove
    - File sys_main.c 2 Remove
  - File DD.dil 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Vinayakam Mani	Author & Moderator	1h 8m	65	Done
Sean Nash	Reviewer - Complete	3h 22m	65	Add a blank line between function and end group marker.
Michael Garthwaite	Reviewer - Complete	12m
Dara Navaei	Reviewer - 10% reviewed	5m
jpaguio (deleted user)	Reviewer - 0% reviewed
Total		4h 49m	130

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/firmware/App/Drivers/BalancingChamber.c Deleted

Click to load diff

/firmware/App/Drivers/BalancingChamber.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DD-LEAH-1971-1

DD-LEAH-1971_DD Integration Changes

DD-LEAH-1971-1 130

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DD-LEAH-1971_DD Integration Changes

DD-LEAH-1971-1 130

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time