Remove space after 'Supply'.

Align the value declaration indentation.

looks you are already checking this state in a line above.

It looks like you deleted it instead of fixing it.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to check heparin bolus volume > 0 too.

Don't we need to check this too still?

Do we need to reset authStartTime here before we go to next state?

Put positive case first ( TRUE == ...), then alarm and reject cases.

No occlusion sensor in Leahi. Delete variable and references to it.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

What is this flag for? And why is it only set here and not above where test passed.
Also, we are going to the loaded check state, but we are not requesting a scan first.

Local declarations should come first - move up above reset function above.

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

I meant that you should move this function up, not init function down.

Change to initDrySelfTests() and move to top (should be first function).

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

Why is this commented out?

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

I think this enum should be in a different header file. I don't think this unit uses this enum.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

I think isSectorStartAddress is a better function name.

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

don't forget to add function headers.