origTreatmentParams should be an output?

Please enclose each condition in parenthesis

Can you please move the TODO comment above this line?

Please add a comment for this check.

Please add @param

Please add @param

treatParamsConfirmed should be an output?

Delete extra line

Please assign it to FALSE

Please add details of you message Id by using this format.

@details \b Message \b Sent:

Place add \b before Outputs.

Place add \b before Outputs.

Why did we remove this? This is needed for BC Switch only condition.

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Remove start state.

Updated

updated

Yes, removed

Removed

yes, removed

Changed

Removed

Removed

Removed

Added