Fisheye on td-firmware/firmware/App/Drivers/GPIO.h https://devapps.diality.us/changelog/~br%3DLEAH-282-fw-td-integration-testing/td-firmware/firmware/App/Drivers/GPIO.h Recent activity in "td-firmware" under directory /firmware/App/Drivers/GPIO.h TD-LEAH-838-1: closed by Sean Nash Mon, 24 Feb 2025 15:26:06 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash Closed TD-LEAH-838-1 ]]> TD-LEAH-838-1: reviewers finished Mon, 24 Feb 2025 13:46:57 -0800 https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Vinayakam Mani and Michael Garthwaite finished reviewing TD-LEAH-838-1 TD-LEAH-838_FW TD Gas Liquid Transfer Pump ]]> TD-LEAH-838-1: started by Sean Nash Mon, 24 Feb 2025 13:22:23 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash started review TD-LEAH-838-1 ]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 15:02:48 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Fixed." Fri, 21 Feb 2025 14:42:41 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21540 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21540 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Fixed.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:42:03 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21539 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21539 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:38:59 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21538 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21538 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:36:32 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21537 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21537 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:34:20 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21536 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21536 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:32:27 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21535 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21535 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:30:50 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21534 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21534 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "I would say we are required to explicitly typec..." Fri, 21 Feb 2025 14:27:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21533 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21533 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

]]> TD-LEAH-838-1: comment by Sean Nash "Removed TODO." Fri, 21 Feb 2025 14:25:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21532 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21532 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Removed TODO.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:23:51 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21531 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21531 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:14:51 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21530 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21530 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:13:11 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21529 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21529 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:11:07 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21528 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21528 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Yes. Done." Fri, 21 Feb 2025 14:10:35 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21527 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21527 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Yes. Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Change has not happened yet in Denali. I will ..." Fri, 21 Feb 2025 14:09:41 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21526 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21526 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Change has not happened yet in Denali. I will follow up with Dara after change is made.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:00:38 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21525 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21525 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "Do we want to change STATE_CLOSED to CMN_TO_NO_..." Thu, 20 Feb 2025 16:01:00 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21522 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21522 Vinayakam Mani commented on TD-LEAH-838-1

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

]]> TD-LEAH-838-1: comment by Vinayakam Mani "3-way" Thu, 20 Feb 2025 15:57:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21521 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21521 Vinayakam Mani commented on TD-LEAH-838-1

3-way

]]> TD-LEAH-838-1: comment by Vinayakam Mani "May be add a check to validate the power level ..." Thu, 20 Feb 2025 15:51:20 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21520 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21520 Vinayakam Mani commented on TD-LEAH-838-1

May be add a check to validate the power level between 0 to 255.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "No Alarm, Add Event ID." Thu, 20 Feb 2025 15:49:02 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21519 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21519 Vinayakam Mani commented on TD-LEAH-838-1

No Alarm, Add Event ID.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "MotorState to MotorPowerLevel - across file." Thu, 20 Feb 2025 15:46:39 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21518 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21518 Vinayakam Mani commented on TD-LEAH-838-1

MotorState to MotorPowerLevel - across file.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "Please adjust the alignment(few #defines)" Thu, 20 Feb 2025 15:38:12 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21517 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21517 Vinayakam Mani commented on TD-LEAH-838-1

Please adjust the alignment(few #defines)

]]> TD-LEAH-838-1: comment by Vinayakam Mani "isAutoControlling?" Thu, 20 Feb 2025 15:33:49 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21516 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21516 Vinayakam Mani commented on TD-LEAH-838-1

isAutoControlling?

]]> TD-LEAH-838-1: comment by Vinayakam Mani "please add description/details along with the M..." Thu, 20 Feb 2025 15:31:49 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21515 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21515 Vinayakam Mani commented on TD-LEAH-838-1

please add description/details along with the Message ID

]]> TD-LEAH-838-1: comment by Vinayakam Mani "Do we need explicit typecast to U32?" Thu, 20 Feb 2025 15:30:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21514 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21514 Vinayakam Mani commented on TD-LEAH-838-1

Do we need explicit typecast to U32?

]]> TD-LEAH-838-1: comment by Vinayakam Mani "#define the 1 and 0." Thu, 20 Feb 2025 15:20:28 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21513 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21513 Vinayakam Mani commented on TD-LEAH-838-1

#define the 1 and 0.

]]>