Fisheye on td-firmware/firmware/App/Modes/ModeService.c https://devapps.diality.us/changelog/~br%3DLEAH-282-fw-td-integration-testing/td-firmware/firmware/App/Modes/ModeService.c Recent activity in "td-firmware" under directory /firmware/App/Modes/ModeService.c TD-LDT-469-1: closed by Sean Nash Mon, 09 Jun 2025 15:12:48 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1 https://devapps.diality.us/cru/TD-LDT-469-1 Sean Nash Closed TD-LDT-469-1 ]]> TD-LDT-469-1: reviewers finished Mon, 09 Jun 2025 10:16:17 -0700 https://devapps.diality.us/cru/TD-LDT-469-1 https://devapps.diality.us/cru/TD-LDT-469-1 Michael Garthwaite and Vinayakam Mani finished reviewing TD-LDT-469-1 TD-LDT-469_Treatment Parameters Create RX ]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 10:00:11 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22036 https://devapps.diality.us/cru/TD-LDT-469-1/#c22036 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:57:27 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22035 https://devapps.diality.us/cru/TD-LDT-469-1/#c22035 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:55:50 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22034 https://devapps.diality.us/cru/TD-LDT-469-1/#c22034 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:53:56 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22033 https://devapps.diality.us/cru/TD-LDT-469-1/#c22033 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:53:21 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22032 https://devapps.diality.us/cru/TD-LDT-469-1/#c22032 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Added." Tue, 20 May 2025 09:52:30 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22031 https://devapps.diality.us/cru/TD-LDT-469-1/#c22031 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Added.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:49:04 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22030 https://devapps.diality.us/cru/TD-LDT-469-1/#c22030 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Vinayakam Mani "DD. Search DG and replace in file." Mon, 19 May 2025 14:00:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22029 https://devapps.diality.us/cru/TD-LDT-469-1/#c22029 Vinayakam Mani commented on TD-LDT-469-1

DD. Search DG and replace in file.

]]> TD-LDT-469-1: comment by Vinayakam Mani "Fill in outputs." Mon, 19 May 2025 13:37:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22028 https://devapps.diality.us/cru/TD-LDT-469-1/#c22028 Vinayakam Mani commented on TD-LDT-469-1

Fill in outputs.

]]> TD-LDT-469-1: comment by Vinayakam Mani "Current Eject motor set speed?" Mon, 19 May 2025 13:32:07 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22027 https://devapps.diality.us/cru/TD-LDT-469-1/#c22027 Vinayakam Mani commented on TD-LDT-469-1

Current Eject motor set speed?

]]> TD-LDT-469-1: comment by Vinayakam Mani "Update header" Mon, 19 May 2025 13:28:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22026 https://devapps.diality.us/cru/TD-LDT-469-1/#c22026 Vinayakam Mani commented on TD-LDT-469-1

Update header

]]> TD-LDT-469-1: comment by Vinayakam Mani "Please add header." Mon, 19 May 2025 13:25:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22025 https://devapps.diality.us/cru/TD-LDT-469-1/#c22025 Vinayakam Mani commented on TD-LDT-469-1

Please add header.

]]> TD-LDT-469-1: comment by Vinayakam Mani "Update Message ID and I/O sections." Mon, 19 May 2025 13:24:17 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22024 https://devapps.diality.us/cru/TD-LDT-469-1/#c22024 Vinayakam Mani commented on TD-LDT-469-1

Update Message ID and I/O sections.

]]> TD-LDT-469-1: comment by Vinayakam Mani "ejector driver/module. Update the Outputs below..." Mon, 19 May 2025 10:48:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22023 https://devapps.diality.us/cru/TD-LDT-469-1/#c22023 Vinayakam Mani commented on TD-LDT-469-1

ejector driver/module. Update the Outputs below.

]]> TD-LDT-469-1: started by Dara Navaei Thu, 01 May 2025 09:07:38 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LDT-469-1 https://devapps.diality.us/cru/TD-LDT-469-1 Dara Navaei started review TD-LDT-469-1 ]]> TD-LEAH-838-1: closed by Sean Nash Mon, 24 Feb 2025 15:26:06 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash Closed TD-LEAH-838-1 ]]> TD-LEAH-838-1: reviewers finished Mon, 24 Feb 2025 13:46:57 -0800 https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Vinayakam Mani and Michael Garthwaite finished reviewing TD-LEAH-838-1 TD-LEAH-838_FW TD Gas Liquid Transfer Pump ]]> TD-LEAH-838-1: started by Sean Nash Mon, 24 Feb 2025 13:22:23 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash started review TD-LEAH-838-1 ]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 15:02:48 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Fixed." Fri, 21 Feb 2025 14:42:41 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21540 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21540 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Fixed.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:42:03 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21539 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21539 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:38:59 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21538 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21538 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:36:32 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21537 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21537 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:34:20 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21536 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21536 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:32:27 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21535 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21535 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:30:50 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21534 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21534 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "I would say we are required to explicitly typec..." Fri, 21 Feb 2025 14:27:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21533 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21533 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

]]> TD-LEAH-838-1: comment by Sean Nash "Removed TODO." Fri, 21 Feb 2025 14:25:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21532 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21532 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Removed TODO.

]]>