Fisheye on dialin/tests/hd_valves_test.py https://devapps.diality.us/changelog/~br%3DUI_S63/dialin/tests/hd_valves_test.py Recent activity in "dialin" under directory /tests/hd_valves_test.py DIALIN-DENBUG-280-4: closed by Michael Garthwaite Wed, 06 Nov 2024 15:20:04 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Michael Garthwaite Closed DIALIN-DENBUG-280-4 ]]> DIALIN-DENBUG-280-1: closed by Michael Garthwaite Wed, 06 Nov 2024 15:19:54 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Michael Garthwaite Closed DIALIN-DENBUG-280-1 ]]> DIALIN-DENBUG-280-4: reviewers finished Mon, 04 Nov 2024 10:29:29 -0800 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Sean Nash finished reviewing DIALIN-DENBUG-280-4 DIALIN-DENBUG-280_Issues With HD Broadcast P1 ]]> DIALIN-DENBUG-280-4: started by Dara Navaei Sat, 02 Nov 2024 16:01:22 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Dara Navaei started review DIALIN-DENBUG-280-4 ]]> DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B Thu, 31 Oct 2024 11:03:43 -0700 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei joined DIALIN-DENBUG-280-1 DIALIN-DENBUG-280_Issues With HD Broadcast P1B ]]> DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B Thu, 31 Oct 2024 11:03:43 -0700 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1 DIALIN-DENBUG-280_Issues With HD Broadcast P1B ]]> DIALIN-DENBUG-280-1: started by Dara Navaei Thu, 31 Oct 2024 11:02:51 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei started review DIALIN-DENBUG-280-1 ]]> DIALIN-DIAL-299-1: closed by Michael Garthwaite Mon, 01 Jul 2024 10:16:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DIAL-299-1 https://devapps.diality.us/cru/DIALIN-DIAL-299-1 Michael Garthwaite Closed DIALIN-DIAL-299-1 ]]> DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..." Mon, 01 Jul 2024 10:16:33 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DIAL-299-1/#c19797 https://devapps.diality.us/cru/DIALIN-DIAL-299-1/#c19797 Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

]]> DIALIN-DIAL-299-1: started by Dara Navaei Wed, 26 Jun 2024 12:01:20 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DIAL-299-1 https://devapps.diality.us/cru/DIALIN-DIAL-299-1 Dara Navaei started review DIALIN-DIAL-299-1 ]]> DIALIN-DEN-2652-1: closed by Dara Navaei Thu, 19 Oct 2023 13:18:59 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-2652-1 https://devapps.diality.us/cru/DIALIN-DEN-2652-1 Dara Navaei Closed DIALIN-DEN-2652-1 ]]> DIALIN-DEN-2652-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 13:18:54 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-2652-1/#c19200 https://devapps.diality.us/cru/DIALIN-DEN-2652-1/#c19200 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-2652-1

RESOLVED

]]> DIALIN-DEN-2652-1: reviewers resumed Thu, 19 Oct 2023 13:17:50 -0700 https://devapps.diality.us/cru/DIALIN-DEN-2652-1 https://devapps.diality.us/cru/DIALIN-DEN-2652-1 plucia  (deleted user) and Sean Nash resumed reviewing DIALIN-DEN-2652-1 DIALIN-DEN-2652_DG Valve Control 1 of 2 ]]> DIALIN-DEN-2652-1: started by Dara Navaei Thu, 19 Oct 2023 13:17:49 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-2652-1 https://devapps.diality.us/cru/DIALIN-DEN-2652-1 Dara Navaei started review DIALIN-DEN-2652-1 ]]> DIALIN-DEN-11750-1: closed by Dara Navaei Thu, 03 Mar 2022 16:50:52 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1 https://devapps.diality.us/cru/DIALIN-DEN-11750-1 Dara Navaei Closed DIALIN-DEN-11750-1 ]]> DIALIN-DEN-11750-1: reviewers finished Wed, 02 Mar 2022 12:39:44 -0800 https://devapps.diality.us/cru/DIALIN-DEN-11750-1 https://devapps.diality.us/cru/DIALIN-DEN-11750-1 Michael Garthwaite and Sean Nash finished reviewing DIALIN-DEN-11750-1 DIALIN-DEN-11750_DG Dev Dialysate Temperature Control Tune Up ]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Tue, 01 Mar 2022 13:06:04 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12172 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12172 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Dara Navaei "This variable was very temporary. I deleted it." Tue, 01 Mar 2022 12:56:02 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12170 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12170 Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

This variable was very temporary. I deleted it.

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "I don't have an issue with temporary features o..." Tue, 01 Mar 2022 10:35:42 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12156 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12156 Michael Garthwaite commented on DIALIN-DEN-11750-1

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Feb 2022 12:55:45 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12057 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12057 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Feb 2022 12:55:33 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12056 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12056 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Feb 2022 12:55:05 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12055 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12055 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Feb 2022 12:53:48 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12054 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12054 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Feb 2022 12:53:32 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12053 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12053 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Feb 2022 12:53:18 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12052 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12052 Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

]]> DIALIN-DEN-11750-1: comment by Dara Navaei "I made it like HD." Wed, 23 Feb 2022 11:24:38 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12051 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12051 Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

I made it like HD.

]]> DIALIN-DEN-11750-1: comment by Dara Navaei "Done." Wed, 23 Feb 2022 11:18:22 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12050 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12050 Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

Done.

]]> DIALIN-DEN-11750-1: comment by Dara Navaei "Agreed. I will clean them up gradually. Removed..." Wed, 23 Feb 2022 11:16:23 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12049 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12049 Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

Agreed. I will clean them up gradually. Removed the commented code.

]]> DIALIN-DEN-11750-1: comment by Dara Navaei "Done." Wed, 23 Feb 2022 11:15:50 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12048 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12048 Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

Done.

]]> DIALIN-DEN-11750-1: comment by Dara Navaei "This class is used to wait for the results to b..." Wed, 23 Feb 2022 11:05:04 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12046 https://devapps.diality.us/cru/DIALIN-DEN-11750-1/#c12046 Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

This class is used to wait for the results to be received from firmware. I fixed the order.

]]>