currentInstallState is an input.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

AirPump.h should be above AirTrap.h

Remove extra ;

Can we align comments?

Missing pinch valves (H1 and H19).

Remove this blank line.

please add message id.

We should set all TD actuators here, not just blood pump.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-1, +1)	| History	| Source	| Diff

]]> Fri, 12 Jun 2026 14:01:36 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1 Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4329-1 LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4: ]]> Thu, 11 Jun 2026 22:29:14 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-4013-1 ]]> Wed, 10 Jun 2026 15:24:18 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1 Vendor - TEL - Vijay Pamula Closed LEAHI-TD-FIRMWARE-LDT-3970-1 ]]> Tue, 09 Jun 2026 10:16:03 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1/#c29652 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1/#c29652 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4329-1

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

These should be moved down to an "else" in the if statement below (payload length check).

It doesn't look like these memsets are necessary. Consider removing them.

Remove blank line.

Can you move this down with the other vitals functions?

· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-0, +211)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-0, +22)	| History	| Source	| Diff

]]>