· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/SubstitutionPump.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/SubstitutionPump.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 11 Jun 2026 14:24:17 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4001-1 ]]> Thu, 11 Jun 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4: ]]> Thu, 11 Jun 2026 10:08:28 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

Should we change msg ID from speed to rate?

fixed thanks

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

fixed thanks

this is a set speed in rpm

this is speed in rpm

fixed thanks

fixed thanks

fixed thanks

Change speed to rate.

pumpTargetRate

Change function name to say rate instead of speed

Is this a rate too?

Is this a rate too?

Change speed to rate.

Is currentPumpSpeed actually a rate?

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Align comment.

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.

fixed thanks

Change to pumpTargetRate since mL/min is a rate.

fixed thanks

fixed thanks

fixed thanks