Update header

Align indent.

Add Doxygen comments.

Align indent

0.0F

p40RPMCnts -> typecast to F32.

mention as 30.0F, its being used in float calculations.

p40RPMCnts variable defined as U16, but assigning U32 value.

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Add TODO or revert back changes.

Delete empty line

Add the comment.

Align the indent throughout.

Add comment.

Space before and after paranthesis.

If debug is complete, do you want to revert back to actual values? if you still need it for some more time, please add TODO comment.

Update the comment.

Aling the indentation of value field.

Align the indentation.

· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-2, +2)	| History	| Source	| Diff

]]> Mon, 03 Aug 2026 11:05:10 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4873-2 ]]> Wed, 29 Jul 2026 11:27:33 -0700 Vendor - TEL - Santhoshkumar Reddy Alasandagutti https://devapps.diality.us/changelog/dd-firmware?cs=095866efd8f10bdead490578e7584051d79292f0 https://devapps.diality.us/changelog/dd-firmware?cs=095866efd8f10bdead490578e7584051d79292f0 Vendor - TEL - Santhoshkumar Reddy Alasandagutti committed 095866e on branch LDT-4873-request-add-config-to-disable-c-1, LDT-5102-dd-concentrate-pumps-hardware-d, develop in dd-firmware Revert "Merge branch 'develop' into LDT-5102-dd-concentrate-pumps-hardware-d"

This reverts commit f43d59af8e69ef1459bafe91873ce41cf63a4a75, reversing

changes made to 7f56f07660862bc62524c506699193a7e5f48f96.

· /firmware/App/Controllers/BalancingChamber.c	(-304, +125)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-9, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-4, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-163, +61)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-13, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-51, +16)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-10, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-13, +0)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-4, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-0, +1)	| History	| Source	| Diff
… 9 more files in changeset.

]]> Wed, 29 Jul 2026 04:02:19 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5102-1 ]]> Mon, 27 Jul 2026 14:22:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c30747 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c30747 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4049-1

you need to bring in the new set of valves here as well.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

Align the indent. Replace RO to FP.

· /firmware/App/Controllers/BoostPump.c	(-19, +16)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-26, +6)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-3, +2)	| History	| Source	| Diff

]]>