Fisheye on leahi-dialin/leahi_dialin/dd/modules/events.py

LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:46:36 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Thu, 05 Mar 2026 10:25:20 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Tue, 03 Mar 2026 16:58:49 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-3557-1: comment by Zoltan Miskolci "removed"

Zoltan Miskolci — Tue, 03 Mar 2026 15:28:18 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3557-1

removed

LEAHI-DIALIN-LDT-3557-1: comment by Michael Garthwaite "Remove this extra line"

Michael Garthwaite — Tue, 03 Mar 2026 09:13:22 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-3557-1

Remove this extra line

leahi-dialin (feature/LDT-3800-enhancements-usability-requests): - Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TE...

Zoltan Miskolci — Wed, 25 Feb 2026 18:57:01 -0800

Zoltan Miskolci committed 20c821b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 19 more in leahi-dialin

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

· /leahi_dialin/common/__init__.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs.py

(-49, +1)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-0, +63)

| History

| Source

· /leahi_dialin/common/fp_defs.py

(-37, +1)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs_proxy.py

(-0, +51)

| History

| Source

· /leahi_dialin/common/td_defs.py

(-47, +1)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs_proxy.py

(-0, +61)

| History

| Source

· /leahi_dialin/common/test_config_defs.py

(-2, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-46, +46)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-22, +17)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-9, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-14, +14)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +4)

| History

| Source

| Diff

… 46 more files in changeset.

LEAHI-DIALIN-LDT-3557-1: started by Dara Navaei

Dara Navaei — Fri, 20 Feb 2026 10:46:38 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 22 Jan 2026 10:07:41 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): Merge branch 'LDT-3214-override-refactor' into staging

Zoltan Miskolci — Thu, 22 Jan 2026 10:06:19 -0800

Zoltan Miskolci committed c5bfcf8 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin

Merge branch 'LDT-3214-override-refactor' into staging

· /leahi_dialin/common/dd_defs.py

(-6, +15)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs.py

(-0, +2)

| History

| Source

| Diff

· /leahi_dialin/common/msg_ids.py

(-1, +3)

| History

| Source

| Diff

· /leahi_dialin/common/test_config_defs.py

(-2, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-60, +60)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-31, +157)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-175, +136)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-146, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-104, +48)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-136, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-7, +13)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-149, +66)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-91, +63)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-54, +50)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-110, +59)

| History

| Source

| Diff

… 32 more files in changeset.

leahi-dialin (develop): Merge branch 'LDT-3214-override-refactor' into develop

Zoltan Miskolci — Wed, 21 Jan 2026 20:02:31 -0800

Zoltan Miskolci committed 38e8dd3 on branch develop in leahi-dialin

Merge branch 'LDT-3214-override-refactor' into develop

· /leahi_dialin/common/msg_ids.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-60, +60)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-31, +157)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-175, +136)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-146, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-78, +42)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-136, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-7, +13)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-127, +64)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-91, +63)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-24, +21)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-65, +68)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/temperature_sensors.py

(-113, +69)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/valves.py

(-95, +68)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/voltages.py

(-73, +39)

| History

| Source

| Diff

… 32 more files in changeset.

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Wed, 21 Jan 2026 12:35:59 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-611-1: closed by Zoltan Miskolci

Zoltan Miskolci — Wed, 21 Jan 2026 11:08:14 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-611-1

LEAHI-DIALIN-LDT-611-1: reviewers finished

Wed, 21 Jan 2026 10:31:13 -0800

Raghu Kallala and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-611-1

LEAHI-DIALIN-LDT-611_FP Add Ability TO Override Tempe

LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u...

Wed, 21 Jan 2026 09:47:38 -0800

Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Tue, 20 Jan 2026 15:33:25 -0800

Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-611-1: comment by Zoltan Miskolci "I added the unique decorator back, except for t..."

Zoltan Miskolci — Tue, 20 Jan 2026 10:14:07 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-611-1

I added the unique decorator back, except for the few that have aliases

LEAHI-DIALIN-LDT-611-1: comment by Zoltan Miskolci "Renamed, also flagged for future type change."

Zoltan Miskolci — Tue, 20 Jan 2026 09:32:13 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-611-1

Renamed, also flagged for future type change.

LEAHI-DIALIN-LDT-611-1: comment by Michael Garthwaite ""No one should interact with it or be aware of ..."

Michael Garthwaite — Mon, 19 Jan 2026 10:45:41 -0800

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-611-1

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).

"As we only have 2 version in test at the same time."

Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.

We have the choice to handle the redesign effort then or now.

Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

LEAHI-DIALIN-LDT-611-1: comment by Michael Garthwaite "yes. that's the design consideration. Are we ok..."

Michael Garthwaite — Mon, 19 Jan 2026 11:42:04 -0800

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-611-1

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).

LEAHI-DIALIN-LDT-611-1: comment by Zoltan Miskolci "I am not sure I can assign unique to the dynami..."

Zoltan Miskolci — Mon, 19 Jan 2026 10:44:58 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-611-1

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how much to shift value for it.
Making an alias is more dynamic and not needing separate variables to be maintained for this.

LEAHI-DIALIN-LDT-611-1: comment by Zoltan Miskolci "Enum content of Beta 1.0 and Beta 1.9 is differ..."

Zoltan Miskolci — Mon, 19 Jan 2026 10:41:38 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-611-1

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation.
Making it dynamic makes it that when the beta test config is called the enums are switching content to reflect that.

LEAHI-DIALIN-LDT-611-1: comment by Zoltan Miskolci "Reasons: - No one should interact with it or b..."

Zoltan Miskolci — Mon, 19 Jan 2026 10:33:18 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-611-1

Reasons:

No one should interact with it or be aware of it's existence, so the name shouldn't matter.
As we only have 2 version in test at the same time, I am making an internal variable name that I don't need to rename every 3 months or so.
Needing to make a review smaller with editing less thing makes it faster to be completed...

In case a situation arrives when we will test more version at the same time Alpha, Beta, Beta 1.9, it will require a redesign on the part of enum generation too.

LEAHI-DIALIN-LDT-611-1: comment by Michael Garthwaite "previously we had the unique keyword above our ..."

Michael Garthwaite — Mon, 19 Jan 2026 10:27:51 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-611-1

previously we had the unique keyword above our classes as a developer sanity check to ensure the dev didnt duplicate values in the dict since we dont auto generate this defs.

if i remember correctly, unique is checked when the enum class is imported. We test it our unit tests, both test_constructors and test_imports.

The reason we currently would want to keep unique is because the DialinEnum class has the method has_value(). Without knowing the current usage of this function from our users, it will impact users expected behavior.

My question to you: Should we continue to test and check how the defs for duplicates?

LEAHI-DIALIN-LDT-611-1: comment by Michael Garthwaite "This should be renamed to be more concise and a..."

Michael Garthwaite — Mon, 19 Jan 2026 10:18:59 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-611-1

This should be renamed to be more concise and allow flexibility as more HW revisions come. What is next gen? All BETAs? BETA 1.9? Beta 2.0? DVT?

LEAHI-DIALIN-LDT-611-1: comment by Michael Garthwaite "What is the intention of making our defs dynami..."

Michael Garthwaite — Mon, 19 Jan 2026 10:15:49 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-611-1

What is the intention of making our defs dynamic and a class object rather keeping it a class?

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Fixed namin typos - Reworked dd temperature broadcast to address new values

Zoltan Miskolci — Wed, 14 Jan 2026 12:16:14 -0800

Zoltan Miskolci committed 17b02f2 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin

- Fixed namin typos - Reworked dd temperature broadcast to address new values

· /leahi_dialin/common/dd_defs.py	(-8, +11)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs.py	(-3, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-3, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/events.py	(-5, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/pressure_sensors.py	(-3, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/temperature_sensors.py	(-56, +44)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/pressure_sensors.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/temperatures.py	(-2, +2)	\| History	\| Source	\| Diff

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Updated modules to use the new enum structure

Zoltan Miskolci — Tue, 13 Jan 2026 15:20:23 -0800

Zoltan Miskolci committed d27c402 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin

- Updated modules to use the new enum structure

· /leahi_dialin/dd/dialysate_delivery.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-5, +5)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-56, +56)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-15, +21)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-43, +43)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-40, +40)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-28, +28)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-7, +7)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-11, +18)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/temperature_sensors.py

(-45, +45)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/valves.py

(-45, +45)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/voltages.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/td/modules/air_pump.py

(-6, +6)

| History

| Source

| Diff

· /leahi_dialin/td/modules/air_trap.py

(-17, +17)

| History

| Source

| Diff

… 11 more files in changeset.

LEAHI-DIALIN-LDT-611-1: reviewers added to LEAHI-DIALIN-LDT-611_FP Add Ability TO Override Te...

Tue, 13 Jan 2026 14:12:18 -0800

Dara Navaei added Michael Garthwaite to LEAHI-DIALIN-LDT-611-1

LEAHI-DIALIN-LDT-611_FP Add Ability TO Override Tempe

LEAHI-DIALIN-LDT-611-1: reviewers removed from LEAHI-DIALIN-LDT-611_FP Add Ability TO Override Te...

Tue, 13 Jan 2026 14:12:18 -0800

Dara Navaei removed jpaguio (deleted user) from LEAHI-DIALIN-LDT-611-1

LEAHI-DIALIN-LDT-611_FP Add Ability TO Override Tempe

LEAHI-DIALIN-LDT-611-1: reviewers resumed

Tue, 13 Jan 2026 14:11:45 -0800

Sean Nash resumed reviewing LEAHI-DIALIN-LDT-611-1

LEAHI-DIALIN-LDT-611_FP Add Ability TO Override Tempe