Fisheye on leahi-dialin/leahi_dialin/td/modules/buttons.py https://devapps.diality.us/changelog/~br%3Ddevelop/leahi-dialin/leahi_dialin/td/modules/buttons.py Recent activity in "leahi-dialin" under directory /leahi_dialin/td/modules/buttons.py LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci Thu, 05 Mar 2026 10:46:36 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1 ]]> LEAHI-DIALIN-LDT-3557-1: reviewers finished Thu, 05 Mar 2026 10:25:20 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1 LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables ]]> LEAHI-DIALIN-LDT-3557-1: reviewers finished Tue, 03 Mar 2026 16:58:49 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1 LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables ]]> LEAHI-DIALIN-LDT-3557-1: comment by Zoltan Miskolci "removed" Tue, 03 Mar 2026 15:28:18 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27734 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27734 Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3557-1

removed

]]> LEAHI-DIALIN-LDT-3557-1: comment by Michael Garthwaite "Remove this extra line" Tue, 03 Mar 2026 09:13:22 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27718 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27718 Michael Garthwaite commented on LEAHI-DIALIN-LDT-3557-1

Remove this extra line

]]> leahi-dialin (feature/LDT-3800-enhancements-usability-requests): - Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TE... Wed, 25 Feb 2026 18:57:01 -0800 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=20c821bd230fc7689a0275a2918981669ff5cc19 https://devapps.diality.us/changelog/leahi-dialin?cs=20c821bd230fc7689a0275a2918981669ff5cc19 Zoltan Miskolci committed 20c821b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 19 more in leahi-dialin - Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

· /leahi_dialin/common/__init__.py (-3, +3) | History | Source | Diff
· /leahi_dialin/common/dd_defs.py (-49, +1) | History | Source | Diff
· /leahi_dialin/common/dd_defs_proxy.py (-0, +63) | History | Source
· /leahi_dialin/common/fp_defs.py (-37, +1) | History | Source | Diff
· /leahi_dialin/common/fp_defs_proxy.py (-0, +51) | History | Source
· /leahi_dialin/common/td_defs.py (-47, +1) | History | Source | Diff
· /leahi_dialin/common/td_defs_proxy.py (-0, +61) | History | Source
· /leahi_dialin/common/test_config_defs.py (-2, +1) | History | Source | Diff
· /leahi_dialin/dd/dialysate_delivery.py (-46, +46) | History | Source | Diff
· /leahi_dialin/dd/modules/alarms.py (-22, +17) | History | Source | Diff
· /leahi_dialin/dd/modules/balancing_chamber.py (-9, +10) | History | Source | Diff
· /leahi_dialin/dd/modules/blood_leak.py (-14, +14) | History | Source | Diff
· /leahi_dialin/dd/modules/concentrate_pump.py (-3, +4) | History | Source | Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py (-3, +4) | History | Source | Diff
· /leahi_dialin/dd/modules/dd_test_configs.py (-2, +4) | History | Source | Diff
… 46 more files in changeset.
]]> LEAHI-DIALIN-LDT-3557-1: started by Dara Navaei Fri, 20 Feb 2026 10:46:38 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Dara Navaei started review LEAHI-DIALIN-LDT-3557-1 ]]> LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci Thu, 22 Jan 2026 10:07:41 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-3214-1: reviewers finished Wed, 21 Jan 2026 12:35:59 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions ]]> LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u... Wed, 21 Jan 2026 09:47:38 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions ]]> LEAHI-DIALIN-LDT-3214-1: reviewers finished Tue, 20 Jan 2026 15:33:25 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions ]]> LEAHI-DIALIN-LDT-3214-1: comment by Zoltan Miskolci "Putting the aliases at the end makes them group..." Mon, 12 Jan 2026 17:07:56 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26254 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26254 Zoltan Miskolci replied to Sean Nash in LEAHI-DIALIN-LDT-3214-1

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

]]> LEAHI-DIALIN-LDT-3214-1: comment by Sean Nash "Why move this here? Seems like an odd placemen..." Mon, 12 Jan 2026 13:04:02 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26252 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26252 Sean Nash commented on LEAHI-DIALIN-LDT-3214-1

Why move this here? Seems like an odd placement so far away from D14.

]]> leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Removed some empty lines to have the same formating throgh the files Fri, 09 Jan 2026 11:41:12 -0800 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=18c90a1b2b6c7339bdd192a2d2fac32f2b8a35df https://devapps.diality.us/changelog/leahi-dialin?cs=18c90a1b2b6c7339bdd192a2d2fac32f2b8a35df Zoltan Miskolci committed 18c90a1 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin - Removed some empty lines to have the same formating throgh the files

· /leahi_dialin/common/fp_defs.py (-1, +1) | History | Source | Diff
· /leahi_dialin/common/override_templates.py (-2, +0) | History | Source | Diff
· /leahi_dialin/dd/dialysate_delivery.py (-9, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/alarms.py (-1, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/balancing_chamber.py (-5, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/blood_leak.py (-1, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/concentrate_pump.py (-8, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py (-4, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/dd_test_configs.py (-2, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/dialysate_pump.py (-7, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/gen_dialysate.py (-6, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/heaters.py (-2, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/levels.py (-3, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/post_gen_dialysate.py (-1, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/pre_gen_dialysate.py (-1, +0) | History | Source | Diff
… 39 more files in changeset.
]]> leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-2787 - Added opmode change request to dd_proxy - Updated overrides in TD module Thu, 08 Jan 2026 17:42:45 -0800 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=03dc6c3ff80d7f76a5b6438ba067e02a37e2ce93 https://devapps.diality.us/changelog/leahi-dialin?cs=03dc6c3ff80d7f76a5b6438ba067e02a37e2ce93 Zoltan Miskolci committed 03dc6c3 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin LDT-2787 - Added opmode change request to dd_proxy - Updated overrides in TD module

· /leahi_dialin/common/override_templates.py (-2, +2) | History | Source | Diff
· /leahi_dialin/common/td_defs.py (-2, +2) | History | Source | Diff
· /leahi_dialin/dd/modules/alarms.py (-3, +6) | History | Source | Diff
· /leahi_dialin/dd/modules/dd_test_configs.py (-1, +1) | History | Source | Diff
· /leahi_dialin/fp/modules/alarms.py (-41, +81) | History | Source | Diff
· /leahi_dialin/fp/modules/events.py (-7, +14) | History | Source | Diff
· /leahi_dialin/fp/modules/fp_test_configs.py (-86, +60) | History | Source | Diff
· /leahi_dialin/td/modules/air_pump.py (-62, +40) | History | Source | Diff
· /leahi_dialin/td/modules/air_trap.py (-153, +90) | History | Source | Diff
· /leahi_dialin/td/modules/alarms.py (-274, +149) | History | Source | Diff
· /leahi_dialin/td/modules/blood_flow.py (-254, +131) | History | Source | Diff
· /leahi_dialin/td/modules/bubble_detector.py (-68, +39) | History | Source | Diff
· /leahi_dialin/td/modules/buttons.py (-51, +29) | History | Source | Diff
· /leahi_dialin/td/modules/ejector.py (-83, +41) | History | Source | Diff
· /leahi_dialin/td/modules/events.py (-6, +14) | History | Source | Diff
… 5 more files in changeset.
]]> LEAHI-DIALIN-LDT-3214-1: started by Dara Navaei Tue, 06 Jan 2026 16:33:01 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Dara Navaei started review LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-3214-1: Needs Fixing by Dara Navaei Tue, 23 Dec 2025 18:33:43 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Dara Navaei Needs Fixing LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-3214-1: Abandoned by Dara Navaei Tue, 23 Dec 2025 18:33:39 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Dara Navaei Abandoned LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-2300-1: closed by jpaguio Thu, 25 Sep 2025 14:42:40 -0700 jpaguio https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1 jpaguio  (deleted user) Closed LEAHI-DIALIN-LDT-2300-1 ]]> LEAHI-DIALIN-LDT-2300-1: reviewers finished Thu, 25 Sep 2025 14:35:27 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1 Dara Navaei and Sean Nash finished reviewing LEAHI-DIALIN-LDT-2300-1 LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received ]]> leahi-dialin (feature/LDT-3855-sw-enhc-general-alarm): LDT-2300: Resolved code review comments Thu, 25 Sep 2025 12:57:32 -0700 Jonny Paguio <jpaguio@diality.com> https://devapps.diality.us/changelog/leahi-dialin?cs=ec8a2600b9e8cf6fe7e02c200a1c24221ca86863 https://devapps.diality.us/changelog/leahi-dialin?cs=ec8a2600b9e8cf6fe7e02c200a1c24221ca86863 Jonny Paguio <jpaguio@diality.com> committed ec8a260 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1195-dd-request-for-a-variable-for-b and 58 more in leahi-dialin LDT-2300: Resolved code review comments

· /leahi_dialin/dd/modules/alarms.py (-2, +2) | History | Source | Diff
· /leahi_dialin/dd/modules/balancing_chamber.py (-2, +2) | History | Source | Diff
· /leahi_dialin/dd/modules/blood_leak.py (-7, +9) | History | Source | Diff
· /leahi_dialin/dd/modules/concentrate_pump.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/dd_test_configs.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/dialysate_pump.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/gen_dialysate.py (-2, +2) | History | Source | Diff
· /leahi_dialin/dd/modules/heaters.py (-2, +4) | History | Source | Diff
· /leahi_dialin/dd/modules/levels.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/piston_pump.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/pre_gen_dialysate.py (-2, +3) | History | Source | Diff
· /leahi_dialin/dd/modules/pressure_sensors.py (-1, +1) | History | Source | Diff
· /leahi_dialin/dd/modules/spent_chamber_fill.py (-2, +2) | History | Source | Diff
· /leahi_dialin/dd/modules/temperature_sensors.py (-1, +1) | History | Source | Diff
… 26 more files in changeset.
]]> LEAHI-DIALIN-LDT-2300-1: comment by jpaguio "Done - timestamps added to DD, FP, and TD" Thu, 25 Sep 2025 12:16:55 -0700 jpaguio https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24451 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24451 jpaguio  (deleted user) replied to Sean Nash in LEAHI-DIALIN-LDT-2300-1

Done - timestamps added to DD, FP, and TD

]]> LEAHI-DIALIN-LDT-2300-1: comment by jpaguio "Done" Thu, 25 Sep 2025 12:13:29 -0700 jpaguio https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24450 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24450 jpaguio  (deleted user) replied to Sean Nash in LEAHI-DIALIN-LDT-2300-1

Done

]]> LEAHI-DIALIN-LDT-2300-1: comment by jpaguio "Done" Thu, 25 Sep 2025 12:12:50 -0700 jpaguio https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24449 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24449 jpaguio  (deleted user) replied to Sean Nash in LEAHI-DIALIN-LDT-2300-1

Done

]]> LEAHI-DIALIN-LDT-2300-1: comment by jpaguio "Done" Thu, 25 Sep 2025 12:11:07 -0700 jpaguio https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24448 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24448 jpaguio  (deleted user) replied to Sean Nash in LEAHI-DIALIN-LDT-2300-1

Done

]]> LEAHI-DIALIN-LDT-2300-1: comment by jpaguio "I'm not sure I really understand the question h..." Mon, 22 Sep 2025 14:24:43 -0700 jpaguio https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24417 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24417 jpaguio  (deleted user) replied to Sean Nash in LEAHI-DIALIN-LDT-2300-1

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

]]> LEAHI-DIALIN-LDT-2300-1: comment by Sean Nash "No timestamp?" Mon, 22 Sep 2025 09:48:29 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24400 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24400 Sean Nash commented on LEAHI-DIALIN-LDT-2300-1

No timestamp?

]]> LEAHI-DIALIN-LDT-2300-1: comment by Sean Nash "I didn't see dbg variables in the publish list ..." Mon, 22 Sep 2025 09:45:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24399 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24399 Sean Nash commented on LEAHI-DIALIN-LDT-2300-1

I didn't see dbg variables in the publish list above.

]]> LEAHI-DIALIN-LDT-2300-1: comment by Sean Nash "Is msg_id_dd_heaters_data really being publishe..." Mon, 22 Sep 2025 09:42:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24398 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24398 Sean Nash commented on LEAHI-DIALIN-LDT-2300-1

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

]]> LEAHI-DIALIN-LDT-2300-1: comment by Sean Nash "Replace "dg" with "dd"." Mon, 22 Sep 2025 09:41:01 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24397 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1/#c24397 Sean Nash commented on LEAHI-DIALIN-LDT-2300-1

Replace "dg" with "dd".

]]>