Fisheye on leahi-dialin/tests

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..."

Michael Garthwaite — Mon, 16 Mar 2026 10:04:25 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

leahi-dialin (LDT-2655-fix_conductivity_override): Merge branch 'staging' into LDT-2655-fix_conductivity_override

Michael Garthwaite — Thu, 12 Mar 2026 14:03:32 -0700

Michael Garthwaite committed 20c66b3 on branch LDT-2655-fix_conductivity_override, develop in leahi-dialin

Merge branch 'staging' into LDT-2655-fix_conductivity_override

· /leahi_dialin/common/__init__.py	(-4, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-134, +98)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-72, +40)	\| History	\| Source	\| Diff
· /leahi_dialin/protocols/CAN.py	(-16, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/protocols/__init__.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/__init__.py	(-1, +1)	\| History	\| Source	\| Diff
· /tests/data_capture_helpers/fp_helpers.py	(-5, +8)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei joined LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-618-1: closed by Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam — Tue, 27 Jan 2026 13:03:23 -0800

Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-DIALIN-LDT-618-1

LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 22 Jan 2026 10:07:41 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1

leahi-dialin (develop): Merge branch 'LDT-3214-override-refactor' into develop

Zoltan Miskolci — Wed, 21 Jan 2026 20:02:31 -0800

Zoltan Miskolci committed 38e8dd3 on branch develop in leahi-dialin

Merge branch 'LDT-3214-override-refactor' into develop

· /leahi_dialin/common/msg_ids.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-60, +60)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-31, +157)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-175, +136)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-146, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-78, +42)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-136, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-7, +13)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-127, +64)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-91, +63)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-24, +21)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-65, +68)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/temperature_sensors.py

(-113, +69)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/valves.py

(-95, +68)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/voltages.py

(-73, +39)

| History

| Source

| Diff

… 32 more files in changeset.

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Wed, 21 Jan 2026 12:35:59 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u...

Wed, 21 Jan 2026 09:47:38 -0800

Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Tue, 20 Jan 2026 15:33:25 -0800

Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: comment by Zoltan Miskolci "Putting the aliases at the end makes them group..."

Zoltan Miskolci — Mon, 12 Jan 2026 17:07:56 -0800

Zoltan Miskolci replied to Sean Nash in LEAHI-DIALIN-LDT-3214-1

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

LEAHI-DIALIN-LDT-3214-1: comment by Sean Nash "Why move this here? Seems like an odd placemen..."

Sean Nash — Mon, 12 Jan 2026 13:04:02 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-3214-1

Why move this here? Seems like an odd placement so far away from D14.

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Removed some empty lines to have the same formating throgh the files

Zoltan Miskolci — Fri, 09 Jan 2026 11:41:12 -0800

Zoltan Miskolci committed 18c90a1 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin

- Removed some empty lines to have the same formating throgh the files

· /leahi_dialin/common/fp_defs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/override_templates.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-9, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-5, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-8, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-4, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-7, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-6, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-3, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

… 39 more files in changeset.

LEAHI-DIALIN-LDT-3214-1: started by Dara Navaei

Dara Navaei — Tue, 06 Jan 2026 16:33:01 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:33:43 -0800

Dara Navaei Needs Fixing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:33:39 -0800

Dara Navaei Abandoned LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-618-1: reviewers finished

Tue, 16 Dec 2025 13:34:27 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-618-1

LEAHI-DIALIN-LDT-618_DD: Add ability to override individual treatment parameters.

LEAHI-DIALIN-LDT-618-1: reviewers finished

Mon, 15 Dec 2025 13:55:49 -0800

Dara Navaei finished reviewing LEAHI-DIALIN-LDT-618-1

LEAHI-DIALIN-LDT-618_DD: Add ability to override individual treatment parameters.

leahi-dialin (LDT-618-DD-Add-ability-to-override-individual-treatment-parameters): LDT-618-DD-Add-ability-to-override-individual-treatment-parameters

Vendor - TEL - Varshini Nagabooshanam — Fri, 12 Dec 2025 09:54:30 -0800

Vendor - TEL - Varshini Nagabooshanam committed 1228659 on branch LDT-618-DD-Add-ability-to-override-individual-treatment-parameters, develop in leahi-dialin

LDT-618-DD-Add-ability-to-override-individual-treatment-parameters

· /tests/dd_login.py

(-2, +2)

| History

| Source

| Diff

leahi-dialin (LDT-618-DD-Add-ability-to-override-individual-treatment-parameters): LDT-618-DD-Add-ability-to-override-individual-treatment-parameters

Vendor - TEL - Varshini Nagabooshanam — Wed, 10 Dec 2025 17:42:41 -0800

Vendor - TEL - Varshini Nagabooshanam committed 44459bf on branch LDT-618-DD-Add-ability-to-override-individual-treatment-parameters, develop in leahi-dialin

LDT-618-DD-Add-ability-to-override-individual-treatment-parameters

· /leahi_dialin/dd/proxies/td_proxy.py	(-1, +1)	\| History	\| Source	\| Diff
· /tests/dd_login.py	(-2, +3)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-2655-1: comment by Sean Nash "Why do we have an "ro" and an "fp" folder? Is ..."

Sean Nash — Tue, 09 Dec 2025 14:26:46 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-2655-1

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

LEAHI-DIALIN-LDT-618-1: comment by Vendor - TEL - Varshini Nagabooshanam "Done"

Vendor - TEL - Varshini Nagabooshanam — Mon, 08 Dec 2025 17:15:29 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Dara Navaei in LEAHI-DIALIN-LDT-618-1

Done

LEAHI-DIALIN-LDT-618-1: comment by Dara Navaei "Remove the old 0xA008. There can only be one me..."

Dara Navaei — Mon, 08 Dec 2025 17:07:54 -0800

Dara Navaei commented on LEAHI-DIALIN-LDT-618-1

Remove the old 0xA008. There can only be one message ID.

LEAHI-DIALIN-LDT-618-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated"

Vendor - TEL - Varshini Nagabooshanam — Mon, 08 Dec 2025 16:45:33 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Dara Navaei in LEAHI-DIALIN-LDT-618-1

Updated

LEAHI-DIALIN-LDT-618-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated."

Vendor - TEL - Varshini Nagabooshanam — Mon, 08 Dec 2025 16:45:13 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Dara Navaei in LEAHI-DIALIN-LDT-618-1

Updated.

LEAHI-DIALIN-LDT-618-1: comment by Dara Navaei "Update the message to 0xA008."

Dara Navaei — Mon, 08 Dec 2025 15:43:10 -0800

Dara Navaei commented on LEAHI-DIALIN-LDT-618-1

Update the message to 0xA008.

LEAHI-DIALIN-LDT-618-1: comment by Dara Navaei "Please add function header."

Dara Navaei — Mon, 08 Dec 2025 15:31:45 -0800

Dara Navaei commented on LEAHI-DIALIN-LDT-618-1

Please add function header.

LEAHI-DIALIN-LDT-618-1: started by Dara Navaei

Dara Navaei — Mon, 08 Dec 2025 14:49:35 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-618-1

leahi-dialin (LDT-618-DD-Add-ability-to-override-individual-treatment-parameters): LDT-618-DD-Add-ability-to-override-individual-treatment-parameters

Vendor - TEL - Varshini Nagabooshanam — Mon, 08 Dec 2025 14:40:27 -0800

Vendor - TEL - Varshini Nagabooshanam committed c08c138 on branch LDT-618-DD-Add-ability-to-override-individual-treatment-parameters, develop in leahi-dialin

LDT-618-DD-Add-ability-to-override-individual-treatment-parameters

· /leahi_dialin/common/msg_ids.py	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/proxies/td_proxy.py	(-1, +15)	\| History	\| Source	\| Diff
· /tests/dd_login.py	(-0, +36)	\| History	\| Source
· /tests/td_login.py	(-0, +25)	\| History	\| Source