Fisheye on leahi-dialin/tools https://devapps.diality.us/changelog/~br%3Ddevelop/leahi-dialin/tools Recent activity in "leahi-dialin" under directory /tools LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci Thu, 22 Jan 2026 10:07:41 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-3214-1: reviewers finished Wed, 21 Jan 2026 12:35:59 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions ]]> LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u... Wed, 21 Jan 2026 09:47:38 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions ]]> LEAHI-DIALIN-LDT-3214-1: reviewers finished Tue, 20 Jan 2026 15:33:25 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1 LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions ]]> LEAHI-DIALIN-LDT-3214-1: comment by Zoltan Miskolci "Putting the aliases at the end makes them group..." Mon, 12 Jan 2026 17:07:56 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26254 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26254 Zoltan Miskolci replied to Sean Nash in LEAHI-DIALIN-LDT-3214-1

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

]]> LEAHI-DIALIN-LDT-3214-1: comment by Sean Nash "Why move this here? Seems like an odd placemen..." Mon, 12 Jan 2026 13:04:02 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26252 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1/#c26252 Sean Nash commented on LEAHI-DIALIN-LDT-3214-1

Why move this here? Seems like an odd placement so far away from D14.

]]> LEAHI-DIALIN-LDT-3214-1: started by Dara Navaei Tue, 06 Jan 2026 16:33:01 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Dara Navaei started review LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-3214-1: Needs Fixing by Dara Navaei Tue, 23 Dec 2025 18:33:43 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Dara Navaei Needs Fixing LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LDT-3214-1: Abandoned by Dara Navaei Tue, 23 Dec 2025 18:33:39 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3214-1 Dara Navaei Abandoned LEAHI-DIALIN-LDT-3214-1 ]]> LEAHI-DIALIN-LEAH-261-1: closed by Michael Garthwaite Wed, 23 Apr 2025 16:29:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-261-1 ]]> LEAHI-DIALIN-LEAH-261-1: reviewers finished Wed, 23 Apr 2025 16:02:54 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Tiffany Mejia and Sean Nash finished reviewing LEAHI-DIALIN-LEAH-261-1 LEAHI-DIALIN-LEAH-261_FW RO Flow Sensor Driver ]]> LEAHI-DIALIN-LEAH-261-1: started by Michael Garthwaite Wed, 23 Apr 2025 15:16:55 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Michael Garthwaite started review LEAHI-DIALIN-LEAH-261-1 ]]> LEAHI-DIALIN-LEAH-261-1: comment by Michael Garthwaite "fixed. Thanks!" Wed, 23 Apr 2025 14:26:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21977 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21977 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-261-1

fixed. Thanks!

]]> LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "Remove extra blank line." Mon, 24 Feb 2025 09:49:44 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21554 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21554 Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

Remove extra blank line.

]]> LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "function header?" Mon, 24 Feb 2025 09:47:55 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21553 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21553 Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

function header?

]]> LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "We should remove DG references throughout. If ..." Mon, 24 Feb 2025 09:44:39 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21552 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21552 Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

]]> LEAHI-DIALIN-LEAH-261-1: started by Dara Navaei Fri, 14 Feb 2025 09:26:45 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Dara Navaei started review LEAHI-DIALIN-LEAH-261-1 ]]> LEAHI-DIALIN-LEAH-136-2: closed by Michael Garthwaite Wed, 22 Jan 2025 14:11:07 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-136-2 ]]> LEAHI-DIALIN-LEAH-139-2: closed by Michael Garthwaite Wed, 22 Jan 2025 14:10:58 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-139-2 ]]> LEAHI-DIALIN-LEAH-142-2: closed by Michael Garthwaite Wed, 22 Jan 2025 14:06:01 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-142-2 ]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "File is reverse_osmosis.py. I actually don't l..." Wed, 22 Jan 2025 13:48:09 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21089 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21089 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

File is reverse_osmosis.py. I actually don't like the file name. Prefer something like filtration_purification.py. Still ok with RO for folders and class names I think - though Jenna uses IOFP.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Match DD op modes in f/w." Wed, 22 Jan 2025 13:45:41 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21088 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21088 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Match DD op modes in f/w.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "DG to DD." Wed, 22 Jan 2025 13:45:19 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21087 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21087 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

DG to DD.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove." Wed, 22 Jan 2025 13:45:03 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21086 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21086 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove." Wed, 22 Jan 2025 13:44:53 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21085 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21085 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove." Wed, 22 Jan 2025 13:44:42 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21084 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21084 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove." Wed, 22 Jan 2025 13:44:36 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21083 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21083 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove." Wed, 22 Jan 2025 13:44:28 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21082 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21082 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove chem disinfect. Leahi not currently sla..." Wed, 22 Jan 2025 13:43:54 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21081 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21081 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove chem disinfect. Leahi not currently slated to have a chem disinfect.

]]> LEAHI-DIALIN-LEAH-136-2: comment by Sean Nash "Remove - we don't have this in Leahi yet." Wed, 22 Jan 2025 13:43:09 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21080 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21080 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

Remove - we don't have this in Leahi yet.

]]>