· /TestSupport.h

(-0, +1)

| History

| Source

| Diff

]]> Wed, 29 Jul 2026 17:37:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Dara Navaei and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Wed, 29 Jul 2026 13:22:15 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4063-1 LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6: ]]> Wed, 29 Jul 2026 11:06:22 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-fwcommon?cs=0b8f91f84aebe54470508381ec6381088901eeba https://devapps.diality.us/changelog/leahi-fwcommon?cs=0b8f91f84aebe54470508381ec6381088901eeba Dara Navaei committed 0b8f91f on branch LDT-3735-non-volatile-memory, LDT-5209-pre-treatment and 2 more in leahi-fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /NVDriver.c	(-2, +5)	| History	| Source	| Diff
· /NVDriver.h	(-2, +5)	| History	| Source	| Diff
· /NVJobQ.c	(-2, +5)	| History	| Source	| Diff
· /NVJobQ.h	(-2, +5)	| History	| Source	| Diff
· /NVMgmt.c	(-2, +5)	| History	| Source	| Diff
· /NVMgmt.h	(-2, +5)	| History	| Source	| Diff
· /TestSupport.h	(-2, +2)	| History	| Source	| Diff
· /WatchdogMgmt.c	(-2, +2)	| History	| Source	| Diff

]]> Wed, 29 Jul 2026 10:55:17 -0700 Vendor - TEL - Suresh Dharnala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c30830 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c30830 Vendor - TEL - Suresh Dharnala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4063-1

Fixed.

Moved.

Move buttons down just above "Comm.h". And why is buttons being included here?

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

I don't see it.

I don't see it.

I would think reason code 1 would work for this - do we really need to add this one?

Fix this.

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

renamed. thanks!

renamed

updated to not have it update always

updated with latest staging implementation.

]]> Mon, 27 Jul 2026 11:21:48 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30743 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30743 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

Not needed because the retry mechanism is going to be deleted in the next ticket.

· /NVJobQ.c

(-1, +0)

| History

| Source

| Diff

]]> Mon, 27 Jul 2026 10:08:19 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4149-1/#c30734 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4149-1/#c30734 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4149-1

What is happening here? Not clear if we need cartridge param. Let's remove it for now.

Remove extra blank line.

Remove extra blank line.