Fisheye on dd-firmware/ https://devapps.diality.us/changelog/~br%3Dgit_cherry_pick/dd-firmware Recent activity in "dd-firmware" under directory / LEAHI-DD-FIRMWARE-LDT-4539-1: reviewers finished Thu, 02 Jul 2026 15:39:25 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4539-1 LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change ]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Add comments." Thu, 02 Jul 2026 15:26:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Add comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Update Comments." Thu, 02 Jul 2026 15:24:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Update Comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Siemens. Space after and before paranthesis." Thu, 02 Jul 2026 15:22:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Siemens. Space after and before paranthesis.

]]> LEAHI-DD-FIRMWARE-LDT-4873-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to... Thu, 02 Jul 2026 14:05:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 Sean Nash added Zoltan Miskolci to LEAHI-DD-FIRMWARE-LDT-4873-1 LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault ]]> LEAHI-DD-FIRMWARE-LDT-4011-2: closed by Vendor - TEL - Jashwant Gantyada Thu, 02 Jul 2026 10:29:24 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-4011-2 ]]> LEAHI-DD-FIRMWARE-LDT-4011-2: reviewers finished Thu, 02 Jul 2026 09:06:59 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4011-2 LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2: ]]> LEAHI-DD-FIRMWARE-LDT-4612-1: closed by Vendor - TEL - Sameer Poyil Wed, 01 Jul 2026 21:08:32 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-4612-1 ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Sameer Poyil "please align this comments with below structure" Wed, 01 Jul 2026 21:04:17 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30334 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30334 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4734-1

please align this comments with below structure

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Sameer Poyil "Please align the comments" Wed, 01 Jul 2026 21:03:36 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30333 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30333 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Please align the comments

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Sameer Poyil "could you please align it ?" Wed, 01 Jul 2026 20:59:54 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30332 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30332 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4734-1

could you please align it ?

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Sean Nash "Can we be a little more specific about what con..." Wed, 01 Jul 2026 18:34:15 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30331 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30331 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

]]> LEAHI-DD-FIRMWARE-LDT-4011-2: reviewers finished Wed, 01 Jul 2026 18:31:53 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4011-2 LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2: ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Sean Nash "Add blank line (should be 2 before test support..." Wed, 01 Jul 2026 18:08:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30330 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30330 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Add blank line (should be 2 before test support banner).

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Sean Nash "Remove blank line." Wed, 01 Jul 2026 18:07:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30329 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30329 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Sean Nash "Needs doxygen comments." Wed, 01 Jul 2026 18:06:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Needs doxygen comments.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Wed, 01 Jul 2026 16:17:49 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4614-1: started by Dara Navaei Wed, 01 Jul 2026 14:32:33 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4614-1 ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:18:13 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30314 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30314 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:18:06 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30313 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30313 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:17:58 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30312 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30312 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!" Wed, 01 Jul 2026 13:17:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30311 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30311 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Michael Garthwaite "Reverted change. Added uncompensated conductivi..." Wed, 01 Jul 2026 13:17:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30310 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30310 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4734-1

Reverted change. Added uncompensated conductivity to the conductivity publishing

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vinayakam Mani "space after if." Wed, 01 Jul 2026 11:02:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30302 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30302 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4734-1

space after if.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vinayakam Mani "Space after if." Wed, 01 Jul 2026 11:02:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30301 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30301 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Space after if.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vinayakam Mani "If it is useful for current and future conducti..." Wed, 01 Jul 2026 10:58:41 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30300 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30300 Vinayakam Mani replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-4734-1

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Deg... Wed, 01 Jul 2026 10:58:54 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vendor - TEL - Jashwant Gantyada "so, are we removing this? I think it is better ..." Wed, 01 Jul 2026 10:49:37 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30295 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30295 Vendor - TEL - Jashwant Gantyada commented on LEAHI-DD-FIRMWARE-LDT-4734-1

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vinayakam Mani "Remove empty line." Wed, 01 Jul 2026 10:57:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30299 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30299 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Remove empty line.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: comment by Vinayakam Mani "Align the indentation" Wed, 01 Jul 2026 10:54:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30297 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1/#c30297 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4734-1

Align the indentation

]]>