Fisheye on application/sources/view/dg/data/disinfect

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

UI-DEN-13198-1: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 28 Sep 2022 16:26:44 -0700

Behrouz NematiPour Closed UI-DEN-13198-1

UI-DEN-13198-1: reviewers finished

Mon, 26 Sep 2022 08:13:58 -0700

Tiffany Mejia finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: comment by jishii "RESOLVED"

jishii — Mon, 26 Sep 2022 07:47:23 -0700

jishii (deleted user) replied to Behrouz NematiPour in UI-DEN-13198-1

RESOLVED

UI-DEN-13198-1: comment by jishii "RESOLVED"

jishii — Mon, 26 Sep 2022 07:47:06 -0700

jishii (deleted user) replied to Behrouz NematiPour in UI-DEN-13198-1

RESOLVED

UI-DEN-13198-1: comment by Behrouz NematiPour "A bug has been created for that. I need to wor..."

Behrouz NematiPour — Sun, 25 Sep 2022 21:56:56 -0700

Behrouz NematiPour replied to jishii (deleted user) in UI-DEN-13198-1

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

UI-DEN-13198-1: comment by Behrouz NematiPour "A bug has been created for that. I need to wor..."

Behrouz NematiPour — Sun, 25 Sep 2022 21:56:26 -0700

Behrouz NematiPour replied to jishii (deleted user) in UI-DEN-13198-1

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

UI-DEN-13198-1: reviewers finished

Fri, 23 Sep 2022 09:16:17 -0700

jishii (deleted user) finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: comment by jishii "Missing square brackets around equality check"

jishii — Mon, 19 Sep 2022 15:58:13 -0700

jishii (deleted user) commented on UI-DEN-13198-1

Missing square brackets around equality check

UI-DEN-13198-1: comment by jishii "During installation last week was having issues..."

jishii — Mon, 19 Sep 2022 15:55:33 -0700

jishii (deleted user) commented on UI-DEN-13198-1

During installation last week was having issues where this check seems to be looking for $CLOUDSYNC_FOLDER in root directory, whereas instructions say to install cloudsync folder in home directory, if I'm understanding correctly the condition should be $HOME$CLOUDSYNC_FOLDER

UI-DEN-13198-1: reviewers added to UI-DEN-13198_UI BN 75

Mon, 19 Sep 2022 14:12:04 -0700

Dara Navaei added jishii (deleted user) to UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: reviewers finished

Fri, 16 Sep 2022 10:12:01 -0700

Sean Nash finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: started by Dara Navaei

Dara Navaei — Thu, 08 Sep 2022 18:05:58 -0700

Dara Navaei started review UI-DEN-13198-1

application (bugfix/DEN-16597-UI-BN-S114): DEN-13645: IMP: Disinfection Remove unused data messages [0x7E00]...

Behrouz NematiPour — Mon, 15 Aug 2022 22:43:03 -0700

Behrouz NematiPour committed ddc4d40 on branch master, @Environement_Swith and 192 more in application

DEN-13645: IMP: Disinfection Remove unused data messages [0x7E00]

- Removed

0x7E00 126 0x040 1 Hz N HD All Standby (disinfect) State "sub-mode (U32-enum) {

0-Flush, (No Flush State required for this state)

1-Heat Disinfect,

2-Chem Disinfect }" (U32) Flush State (U32) Heat Disinfect State (U32) Chem Disinfect State

· /denali.pro	(-4, +0)	\| History	\| Source	\| Diff
· /sources/canbus/MessageGlobals.h	(-1, +0)	\| History	\| Source	\| Diff
· /sources/canbus/MessageInterpreter.cpp	(-3, +0)	\| History	\| Source	\| Diff
· /sources/gui/GuiGlobals.cpp	(-1, +0)	\| History	\| Source	\| Diff
· /sources/gui/GuiGlobals.h	(-1, +0)	\| History	\| Source	\| Diff
· /sources/gui/qml/main.qml	(-2, +0)	\| History	\| Source	\| Diff
· /sources/model/MModel.h	(-5, +0)	\| History	\| Source	\| Diff
· /sources/model/dg/data/disinfect/MDisinfectStatesData.cpp	(-53, +0)	\| History	\| Source	\| Diff
· /sources/model/dg/data/disinfect/MDisinfectStatesData.h	(-90, +0)	\| History	\| Source	\| Diff
· /sources/view/VView.h	(-1, +0)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectStatesData.cpp	(-81, +0)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectStatesData.h	(-86, +0)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): DEN-13645: IMP: Disinfection Remove unused data messages [0x8300]...

Behrouz NematiPour — Mon, 15 Aug 2022 21:30:53 -0700

Behrouz NematiPour committed f1bc4aa on branch master, @Environement_Swith and 192 more in application

DEN-13645: IMP: Disinfection Remove unused data messages [0x8300]

- removed the message:

|0x8300| 131| 0x070| 1 Hz| N| DG| UI| DG Flush Time [each sub state] |(U32) Timeout (secs) (0=no time estimate)| (U32) Timeout countdown (secs)|

· /denali.pro	(-4, +0)	\| History	\| Source	\| Diff
· /sources/canbus/MessageGlobals.h	(-1, +0)	\| History	\| Source	\| Diff
· /sources/canbus/MessageInterpreter.cpp	(-1, +0)	\| History	\| Source	\| Diff
· /sources/gui/GuiGlobals.cpp	(-1, +0)	\| History	\| Source	\| Diff
· /sources/gui/GuiGlobals.h	(-1, +0)	\| History	\| Source	\| Diff
· /sources/gui/qml/main.qml	(-2, +0)	\| History	\| Source	\| Diff
· /sources/model/MModel.h	(-5, +0)	\| History	\| Source	\| Diff
· /sources/model/dg/data/disinfect/MDisinfectDGFlushTimeData.cpp	(-45, +0)	\| History	\| Source	\| Diff
· /sources/model/dg/data/disinfect/MDisinfectDGFlushTimeData.h	(-82, +0)	\| History	\| Source	\| Diff
· /sources/view/VView.h	(-1, +0)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectDGData.cpp	(-62, +0)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectDGData.h	(-60, +0)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Feb 2022 10:10:27 -0800

Dara Navaei committed 27cc308 on branch master, @Environement_Swith and 200 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-7, +6)

| History

| Source

| Diff

· /cppcheck.sh

(-6, +6)

| History

| Source

| Diff

· /cr_objectives.sh

(-0, +15)

| History

| Source

| Diff

· /main.cpp

(-6, +6)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/autostart

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/run.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/setup.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/start.sh

(-6, +6)

| History

| Source

| Diff

… 570 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-9649: Implementation - Yocto configuration...

Behrouz NematiPour — Tue, 10 Aug 2021 10:50:13 -0700

Behrouz NematiPour committed fc329c7 on branch master, @Environement_Swith and 213 more in application

DEN-9649: Implementation - Yocto configuration

- Addressed some frequent code review comments

- Fixed the UI POST AlarmTriggered message

- Added the deleteLater for the QQuickViewer pointer _viewer.

· /denali.pro.user

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +3)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-2, +2)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/MainTimer.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/CanInterface.cpp

(-16, +16)

| History

| Source

| Diff

· /sources/canbus/CanInterface.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.h

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/MessageAcknowModel.h

(-2, +2)

| History

| Source

| Diff

· /sources/canbus/MessageBuilder.cpp

(-18, +18)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.cpp

(-6, +6)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.h

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-5, +5)

| History

| Source

| Diff

… 100 more files in changeset.

UI-DEN-8914-1: closed by Behrouz NematiPour

Behrouz NematiPour — Tue, 06 Jul 2021 00:59:29 -0700

Behrouz NematiPour Closed UI-DEN-8914-1

UI-DEN-8914-1: reviewers finished

Tue, 06 Jul 2021 00:17:14 -0700

pmontazemi (deleted user) finished reviewing UI-DEN-8914-1

UI-DEN-8914_UI Dev BP HR Manual Entry

UI-DEN-8914-1: reviewers finished

Fri, 02 Jul 2021 11:13:02 -0700

plucia (deleted user) finished reviewing UI-DEN-8914-1

UI-DEN-8914_UI Dev BP HR Manual Entry

UI-DEN-8514-2: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 02 Jul 2021 11:10:56 -0700

Behrouz NematiPour Closed UI-DEN-8514-2

UI-DEN-8514-2: reviewers finished

Fri, 02 Jul 2021 10:57:56 -0700

plucia (deleted user) finished reviewing UI-DEN-8514-2

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

UI-DEN-8514-2: reviewers finished

Tue, 29 Jun 2021 08:44:40 -0700

pmontazemi (deleted user) finished reviewing UI-DEN-8514-2

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

application (bugfix/DEN-16597-UI-BN-S114): DEN-DEN-8937: Meetings & Support - General Support...

Behrouz NematiPour — Fri, 25 Jun 2021 17:33:18 -0700

Behrouz NematiPour committed 6233e00 on branch master, @Environement_Swith and 216 more in application

DEN-DEN-8937: Meetings & Support - General Support

- Modified the DG disinfect states message to use the new FW enum instead of the temporary UI one.

· /denali.pro.user	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/GuiGlobals.h	(-9, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/EntryDialog.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/compounds/BPHREntry.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/disinfect/MDisinfectAdjustRequests.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/disinfect/MDisinfectAdjustResponse.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectStatesData.cpp	(-3, +3)	\| History	\| Source	\| Diff
· /sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp	(-6, +6)	\| History	\| Source	\| Diff

UI-DEN-8914-1: started by Dara Navaei

Dara Navaei — Fri, 25 Jun 2021 13:00:39 -0700

Dara Navaei started review UI-DEN-8914-1

application (bugfix/DEN-16597-UI-BN-S114): DEN-8910: Meetings & Support - General Support...

Behrouz NematiPour — Mon, 21 Jun 2021 13:59:11 -0700

Behrouz NematiPour committed 42c029b on branch master, @Environement_Swith and 216 more in application

DEN-8910: Meetings & Support - General Support

- Heat Disinfection bundled states modification

· /denali.pro.user	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/EntryDialog.qml	(-1, +0)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/disinfect/DisinfectStack.qml	(-9, +13)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/treatment/TreatmentStack.qml	(-3, +1)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectStatesData.cpp	(-1, +3)	\| History	\| Source	\| Diff
· /sources/view/dg/data/disinfect/VDisinfectStatesData.h	(-1, +3)	\| History	\| Source	\| Diff

UI-DEN-8514-2: started by Behrouz NematiPour

Behrouz NematiPour — Mon, 14 Jun 2021 11:26:24 -0700

Behrouz NematiPour started review UI-DEN-8514-2