Fisheye on application/cppcheck.sh

UI-DEN-SUNRISE-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:54:28 -0800

Dara Navaei Closed UI-DEN-SUNRISE-1

UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE

Fri, 07 Jun 2024 09:05:01 -0700

Dara Navaei removed Sean Nash and vduong (deleted user) from UI-DEN-SUNRISE-1

UI-DEN-SUNRISE

UI-DEN-SUNRISE-1: started by Dara Navaei

Dara Navaei — Fri, 07 Jun 2024 09:04:34 -0700

Dara Navaei started review UI-DEN-SUNRISE-1

application (DEN-16553-UI-BN-WPA3-Support): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 24 Jan 2024 14:28:27 -0800

Dara Navaei committed 2ef03b2 on branch master, @Environement_Swith and 61 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cho.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-2, +2)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.h

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.h

(-1, +1)

| History

| Source

| Diff

… 598 more files in changeset.

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-4: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 13:21:27 -0700

Sean Nash Closed UI-UCOMMITS-4

UI-UCOMMITS-4: reviewers finished

Thu, 03 Aug 2023 10:52:12 -0700

Dara Navaei finished reviewing UI-UCOMMITS-4

UI Staging Unreviewed Commits

UI-UCOMMITS-4: reviewers finished

Wed, 02 Aug 2023 09:38:59 -0700

Sean Nash finished reviewing UI-UCOMMITS-4

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-4: reviewers added to UI Staging Unreviewed Commits

Mon, 08 May 2023 09:19:54 -0700

Dara Navaei added Behrouz NematiPour to UI-UCOMMITS-4

UI Staging Unreviewed Commits

UI-UCOMMITS-4: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:53:36 -0700

Dara Navaei started review UI-UCOMMITS-4

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 10 Feb 2023 10:12:20 -0800

Dara Navaei committed af8d98b on branch master, @Environement_Swith and 176 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/CanInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageAcknowModel.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.h

(-1, +1)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiView.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/PowerItem.qml

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/DebugDataColumn.qml

(-1, +1)

| History

| Source

| Diff

… 36 more files in changeset.

UI-DEN-14517-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 10 Feb 2023 09:23:43 -0800

Behrouz NematiPour Closed UI-DEN-14517-1

UI-DEN-14517-1: reviewers finished

Fri, 10 Feb 2023 09:23:22 -0800

Michael Garthwaite , vduong (deleted user) and jishii (deleted user) finished reviewing UI-DEN-14517-1

UI-DEN-14517_UI BN S88

UI-DEN-14517-1: comment by vduong "Ok, sounds good. RESOLVED"

vduong — Fri, 10 Feb 2023 09:17:24 -0800

vduong (deleted user) replied to Behrouz NematiPour in UI-DEN-14517-1

Ok, sounds good.

RESOLVED

UI-DEN-14517-1: comment by Behrouz NematiPour "Good point, I agree with the two intervals, it..."

Behrouz NematiPour — Fri, 10 Feb 2023 08:03:55 -0800

Behrouz NematiPour replied to vduong (deleted user) in UI-DEN-14517-1

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

UI-DEN-14517-1: comment by vduong "Only a suggestion: It is a good idea to append..."

vduong — Fri, 10 Feb 2023 07:37:51 -0800

vduong (deleted user) commented on UI-DEN-14517-1

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

UI-DEN-14517-1: comment by vduong "RESOLVED"

vduong — Fri, 10 Feb 2023 07:16:23 -0800

vduong (deleted user) replied to Behrouz NematiPour in UI-DEN-14517-1

RESOLVED

UI-DEN-14517-1: comment by Behrouz NematiPour "Thanks for the feedback. Fixed."

Behrouz NematiPour — Fri, 10 Feb 2023 07:12:48 -0800

Behrouz NematiPour replied to vduong (deleted user) in UI-DEN-14517-1

Thanks for the feedback.
Fixed.

UI-DEN-14517-1: comment by vduong "The variable, destination, itself is a QString,..."

vduong — Fri, 10 Feb 2023 07:03:29 -0800

vduong (deleted user) commented on UI-DEN-14517-1

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

UI-DEN-7044-2: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 01 Feb 2023 00:00:46 -0800

Behrouz NematiPour Closed UI-DEN-7044-2

UI-DEN-7524-3: closed by Behrouz NematiPour

Behrouz NematiPour — Tue, 31 Jan 2023 23:59:33 -0800

Behrouz NematiPour Closed UI-DEN-7524-3

UI-DEN-14294-1: closed by Behrouz NematiPour

Behrouz NematiPour — Tue, 31 Jan 2023 23:54:33 -0800

Behrouz NematiPour Closed UI-DEN-14294-1

UI-DEN-8058-1: closed by Behrouz NematiPour

Behrouz NematiPour — Tue, 31 Jan 2023 23:48:51 -0800

Behrouz NematiPour Closed UI-DEN-8058-1

UI-DEN-14517-1: reviewers added to UI-DEN-14517_UI BN S88

Tue, 31 Jan 2023 23:22:22 -0800

Behrouz NematiPour added jreaume (deleted user) and vduong (deleted user) to UI-DEN-14517-1

UI-DEN-14517_UI BN S88

application (bugfix/DEN-16597-UI-BN-S114): DEN-14524 - Fixed CppCheck...

Behrouz NematiPour — Sat, 21 Jan 2023 19:43:15 -0800

Behrouz NematiPour committed 06400e8 on branch master, @Environement_Swith and 177 more in application

DEN-14524 - Fixed CppCheck

- Fixed CppCheck error for Qt Macros

· /cppcheck.err	(-77, +1228)	\| History	\| Source	\| Diff
· /cppcheck.log	(-628, +884)	\| History	\| Source	\| Diff
· /cppcheck.sh	(-0, +3)	\| History	\| Source	\| Diff
· /sources/canbus/FrameInterface.h	(-4, +3)	\| History	\| Source	\| Diff
· /sources/canbus/MessageAcknowModel.h	(-5, +4)	\| History	\| Source	\| Diff

UI-DEN-14517-1: started by Dara Navaei

Dara Navaei — Tue, 17 Jan 2023 09:01:32 -0800

Dara Navaei started review UI-DEN-14517-1

UI-DEN-14294-1: reviewers finished

Wed, 11 Jan 2023 08:28:01 -0800

Tiffany Mejia and jishii (deleted user) finished reviewing UI-DEN-14294-1

UI-DEN-14294_UI BN S84