Fisheye on dd-firmware/firmware/App https://devapps.diality.us/changelog/~br%3Dmaster/dd-firmware/firmware/App Recent activity in "dd-firmware" under directory /firmware/App LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove this blank line." Tue, 14 Apr 2026 14:35:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28343 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28343 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove this blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Put () around each of the 2 conditions being AN..." Tue, 14 Apr 2026 14:35:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28342 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28342 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Put () around each of the 2 conditions being ANDed.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove blank line." Tue, 14 Apr 2026 14:34:04 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28341 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28341 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove blank line." Tue, 14 Apr 2026 14:33:53 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28340 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28340 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Add a blank line after declarations." Tue, 14 Apr 2026 14:31:50 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28339 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28339 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Add a blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove blank line." Tue, 14 Apr 2026 14:31:36 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28338 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28338 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Should we remove this else if or is it going to..." Tue, 14 Apr 2026 14:31:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28337 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28337 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Should we remove this else if or is it going to be restored later?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra blank lines." Tue, 14 Apr 2026 14:27:24 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28336 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28336 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Shouldn't we be assigning dryBicartState instea..." Tue, 14 Apr 2026 14:26:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28335 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28335 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Why do we need this?" Tue, 14 Apr 2026 14:26:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28334 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28334 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Why do we need this?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra blank line." Tue, 14 Apr 2026 14:24:05 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28333 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28333 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra blank line." Tue, 14 Apr 2026 14:23:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28332 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28332 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Not clear what GENMASK is doing. What do h and..." Tue, 14 Apr 2026 14:19:37 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28331 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28331 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Is this for 64 bit unsigned integer? If not, t..." Tue, 14 Apr 2026 14:15:49 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28330 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28330 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Let's remove this commented line." Tue, 14 Apr 2026 14:14:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28329 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28329 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Let's remove this commented line.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 14:08:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line after declarations." Tue, 14 Apr 2026 14:07:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Why U32? Why not RECOVER_STATE_T?" Tue, 14 Apr 2026 14:05:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Why U32? Why not RECOVER_STATE_T?

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Lower case x" Tue, 14 Apr 2026 14:04:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Lower case x

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Is blood flow in need of a PID controller too?" Tue, 14 Apr 2026 14:02:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Is blood flow in need of a PID controller too?

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Sean Nash "2 blank lines before test support banner" Tue, 14 Apr 2026 13:46:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28323 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28323 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3777-1

2 blank lines before test support banner

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 13:46:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28322 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28322 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3777-1

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 13:46:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28321 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28321 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3777-1

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: reviewers finished Tue, 14 Apr 2026 13:21:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "I don't need to edit this file. I will check wi..." Tue, 14 Apr 2026 11:18:24 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28319 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28319 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

I don't need to edit this file. I will check with Dara to exclude this file from code review.

]]> LEAHI-DD-FIRMWARE-LDT-3904-1: started by Dara Navaei Tue, 14 Apr 2026 11:17:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3904-1 ]]> LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers finished Tue, 14 Apr 2026 11:17:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3777-1 LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes. ]]> LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes. Tue, 14 Apr 2026 11:16:44 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-3777-1 LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes. ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "only maximum 30 float data is allowed. If that ..." Tue, 14 Apr 2026 11:09:50 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28318 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28318 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its a problem . Vinay has to decide it" Tue, 14 Apr 2026 11:08:49 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28317 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28317 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

Its a problem . Vinay has to decide it

]]>