Fisheye on dgfirmware/firmware/App/Modes/ModeChemicalDisinfectFlush.c

DG-DEN-17047-1: closed by Dara Navaei

Dara Navaei — Sat, 08 Nov 2025 14:06:26 -0800

Dara Navaei Closed DG-DEN-17047-1

DG-DEN-14902-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:35 -0800

Dara Navaei Closed DG-DEN-14902-1

DG-DEN-17053-6: closed by Dara Navaei

Dara Navaei — Fri, 20 Sep 2024 16:39:59 -0700

Dara Navaei Closed DG-DEN-17053-6

DG-DEN-17053-6: reviewers finished

Tue, 17 Sep 2024 10:27:48 -0700

Michael Garthwaite finished reviewing DG-DEN-17053-6

DG-DEN-17053_Release 17 Firmware Update

DG-DEN-17053-6: reviewers finished

Mon, 16 Sep 2024 11:10:23 -0700

Sean Nash finished reviewing DG-DEN-17053-6

DG-DEN-17053_Release 17 Firmware Update

DG-DEN-17053-6: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 16 Sep 2024 11:10:15 -0700

Sean Nash replied to Dara Navaei in DG-DEN-17053-6

RESOLVED in CODE WALKTHROUGH.

DG-DEN-17053-6: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 16 Sep 2024 11:10:01 -0700

Sean Nash replied to Dara Navaei in DG-DEN-17053-6

RESOLVED in CODE WALKTHROUGH.

DG-DEN-17053-6: comment by Dara Navaei "Done"

Dara Navaei — Mon, 16 Sep 2024 11:07:10 -0700

Dara Navaei replied to Sean Nash in DG-DEN-17053-6

Done

DG-DEN-17053-6: comment by Dara Navaei "Done"

Dara Navaei — Mon, 16 Sep 2024 11:04:54 -0700

Dara Navaei replied to Sean Nash in DG-DEN-17053-6

Done

DG-DEN-17053-6: comment by Sean Nash "No colon."

Sean Nash — Fri, 13 Sep 2024 12:59:49 -0700

Sean Nash commented on DG-DEN-17053-6

No colon.

DG-DEN-17053-6: comment by Sean Nash "Do not put colons after params."

Sean Nash — Fri, 13 Sep 2024 12:59:26 -0700

Sean Nash commented on DG-DEN-17053-6

Do not put colons after params.

DG-DEN-17053-6: started by Dara Navaei

Dara Navaei — Fri, 13 Sep 2024 12:24:35 -0700

Dara Navaei started review DG-DEN-17053-6

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 12 Sep 2024 13:42:32 -0700

Dara Navaei committed 54abf84 on branch DEN-17093-blood-leak-zeroing-in-treatment-p1b-staging, DEN-17135-concentrate-pump-calibration-staging and 15 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-16970-1: closed by Dara Navaei

Dara Navaei — Thu, 12 Sep 2024 13:40:34 -0700

Dara Navaei Closed DG-DEN-16970-1

DG-DEN-16970-1: reviewers finished

Thu, 12 Sep 2024 13:37:36 -0700

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16970-1

DG-DEN-16970_Stuck IN Cancel Basic Path During Heat Disinfect Passive Cool

DG-DEN-17047-1: started by Dara Navaei

Dara Navaei — Tue, 10 Sep 2024 12:12:10 -0700

Dara Navaei started review DG-DEN-17047-1

DG-DEN-16970-1: reviewers added to DG-DEN-16970_Stuck IN Cancel Basic Path During Hea...

Mon, 09 Sep 2024 16:13:17 -0700

Dara Navaei added pvedantam (deleted user) to DG-DEN-16970-1

DG-DEN-16970_Stuck IN Cancel Basic Path During Heat Disinfect Passive Cool

dgfirmware (release/p1b/staging): DEN-16970 added a check to not set any of the cleaning modes back to cancel water path if any of the cap alarms is activ...

Dara Navaei — Mon, 09 Sep 2024 13:03:04 -0700

Dara Navaei committed fafeb76 on branch DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool, DEN-17093-blood-leak-zeroing-in-treatment-p1b-staging and 16 more in dgfirmware

DEN-16970 added a check to not set any of the cleaning modes back to cancel water path if any of the cap alarms is active

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-9, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-8, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-5, +9)	\| History	\| Source	\| Diff

DG-DEN-16970-1: started by Dara Navaei

Dara Navaei — Mon, 09 Sep 2024 12:58:27 -0700

Dara Navaei started review DG-DEN-16970-1

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Oct 2023 16:50:34 -0700

Dara Navaei committed 2df80d5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 49 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DENBUG-124-1: closed by Dara Navaei

Dara Navaei — Mon, 23 Oct 2023 16:50:01 -0700

Dara Navaei Closed DG-DENBUG-124-1

DG-DENBUG-124-1: reviewers finished

Mon, 23 Oct 2023 09:16:24 -0700

jtaylor (deleted user) finished reviewing DG-DENBUG-124-1

DG-DENBUG-124_Chemical Disinfect Flush Cancel Water Path Running Too Fast

DG-DENBUG-124-1: reviewers finished

Sun, 22 Oct 2023 15:37:57 -0700

Sean Nash and wbracken (deleted user) finished reviewing DG-DENBUG-124-1

DG-DENBUG-124_Chemical Disinfect Flush Cancel Water Path Running Too Fast

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in can...

Dara Navaei — Sat, 21 Oct 2023 13:06:11 -0700

Dara Navaei committed be920d1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware

DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in cancel water path

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-5, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-3, +5)	\| History	\| Source	\| Diff

DG-DENBUG-124-1: started by Dara Navaei

Dara Navaei — Sat, 21 Oct 2023 12:39:37 -0700

Dara Navaei started review DG-DENBUG-124-1

DG-DEN-14316-1: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:02:55 -0700

Dara Navaei Closed DG-DEN-14316-1

DG-DEN-14316-1: reviewers finished

Wed, 18 Oct 2023 21:02:45 -0700

Dara Navaei finished reviewing DG-DEN-14316-1

DG-DEN-14316_Chemical Disinfect

DG-DEN-14316-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:02:07 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14316-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14316-1: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:50:17 -0700

Dara Navaei started review DG-DEN-14316-1