Fisheye on dgfirmware/firmware/App/Services/PIControllers.c https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/firmware/App/Services/PIControllers.c Recent activity in "dgfirmware" under directory /firmware/App/Services/PIControllers.c DG-DEN-17220-1: closed by Dara Navaei Fri, 07 Feb 2025 16:12:39 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei Closed DG-DEN-17220-1 ]]> DG-DEN-17220-1: reviewers finished Fri, 07 Feb 2025 10:03:27 -0800 https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 jpaguio  (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1 DG-DEN-17220_Release 20 P1B Staging ]]> DG-DEN-17220-1: started by Dara Navaei Thu, 06 Feb 2025 14:19:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei started review DG-DEN-17220-1 ]]> DG-DEN-17135-1: closed by Dara Navaei Fri, 31 Jan 2025 16:57:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei Closed DG-DEN-17135-1 ]]> DG-DEN-17135-1: reviewers finished Thu, 30 Jan 2025 10:39:28 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Sean Nash finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: reviewers finished Wed, 29 Jan 2025 17:32:19 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Vinayakam Mani finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Wed, 29 Jan 2025 17:32:01 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 Vinayakam Mani replied to Dara Navaei in DG-DEN-17135-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-17135-1: comment by Dara Navaei "Updated the trigger condition. This is a calibr..." Wed, 29 Jan 2025 17:22:53 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 Dara Navaei replied to Vinayakam Mani in DG-DEN-17135-1

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

]]> DG-DEN-17135-1: comment by Vinayakam Mani "The Trigger condition is little confusing. coul..." Wed, 29 Jan 2025 17:12:35 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 Vinayakam Mani commented on DG-DEN-17135-1

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

]]> DG-DEN-17135-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 29 Jan 2025 17:14:25 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17135-1/#c21291 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21291 Sean Nash replied to Dara Navaei in DG-DEN-17135-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17135-1: comment by Dara Navaei "Removed the typecast." Wed, 29 Jan 2025 16:28:49 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21277 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21277 Dara Navaei replied to Sean Nash in DG-DEN-17135-1

Removed the typecast.

]]> DG-DEN-17135-1: comment by Sean Nash "Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T..." Wed, 29 Jan 2025 16:26:37 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17135-1/#c21276 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21276 Sean Nash commented on DG-DEN-17135-1

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

]]> DG-DEN-17135-1: started by Dara Navaei Wed, 20 Nov 2024 09:54:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei started review DG-DEN-17135-1 ]]> DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-2379-1: closed by Dara Navaei Thu, 19 Oct 2023 08:38:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 Dara Navaei Closed DG-DEN-2379-1 ]]> DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:38:39 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1/#c19110 https://devapps.diality.us/cru/DG-DEN-2379-1/#c19110 Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:38:04 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1/#c19109 https://devapps.diality.us/cru/DG-DEN-2379-1/#c19109 Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:36:42 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1/#c19108 https://devapps.diality.us/cru/DG-DEN-2379-1/#c19108 Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2379-1: reviewers resumed Thu, 19 Oct 2023 08:35:24 -0700 https://devapps.diality.us/cru/DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 pmontazemi  (deleted user) and Sean Nash resumed reviewing DG-DEN-2379-1 DG-DEN-2379_DG Dialysate Temperature 1 of 2 ]]> DG-DEN-2379-1: started by Dara Navaei Thu, 19 Oct 2023 08:35:23 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 Dara Navaei started review DG-DEN-2379-1 ]]> DG-DEN-3421-1: closed by Dara Navaei Thu, 19 Oct 2023 08:34:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei Closed DG-DEN-3421-1 ]]> DG-DEN-3421-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:34:41 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-3421-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-3421-1: reviewers resumed Thu, 19 Oct 2023 08:29:12 -0700 https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 pmontazemi  (deleted user) , qnguyen  (deleted user) and Sean Nash resumed reviewing DG-DEN-3421-1 DG-DEN-3421_DG Heat Disinfection ]]> DG-DEN-3421-1: started by Dara Navaei Thu, 19 Oct 2023 08:29:07 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei started review DG-DEN-3421-1 ]]> DG-DEN-4217-1: closed by Dara Navaei Thu, 19 Oct 2023 08:28:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: reviewers finished Thu, 19 Oct 2023 08:28:27 -0700 https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei , qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DG-DEN-4217-1 DG-DEN-4217_Level and Shock Detection ]]>